Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Disable wrapping source #68181

Merged
merged 3 commits into from Sep 18, 2019
Merged

doc: Disable wrapping source #68181

merged 3 commits into from Sep 18, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Sep 6, 2019

Even a simple typo fix can result in a reflow of a whole paragraph, leading to illegible diffs. The majority of text editors supports wrapping the source code to a comfortable width so it makes sense to me to sacrifice the few that do not rather than the unfortunately line-oriented diff tools.

For GitHub, you can install https://github.com/StylishThemes/GitHub-code-wrap.

cc @samueldr @grahamc

Even a simple typo fix can result in a reflow of a whole paragraph, leading to illegible diffs. The majority of text editors supports wrapping the source code to a comfortable width so it makes sense to me to sacrifice the few that do not rather than the unfortunately line-oriented diff tools.
@jtojnar
Copy link
Contributor Author

jtojnar commented Sep 18, 2019

Here is a screenshot of an editor with code formatted like this and soft-wrapping enabled:

Screenshot from 2019-09-18 22-21-26

@grahamc
Copy link
Member

grahamc commented Sep 18, 2019

(implicit approval of a backport to 19.09 of the change and a reformat there.)

@jtojnar jtojnar merged commit c28659e into NixOS:master Sep 18, 2019
@jtojnar jtojnar deleted the no-wrap-doc branch September 18, 2019 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants