Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Go 1.13 #68135

Merged
merged 31 commits into from Oct 12, 2019
Merged

Add Go 1.13 #68135

merged 31 commits into from Oct 12, 2019

Conversation

rvolosatovs
Copy link
Member

@rvolosatovs rvolosatovs commented Sep 5, 2019 •
edited

Motivation for this change

Upstream update
Seems like progress on #68101 stalled for now, meanwhile I already have a working Go 1.13 derivation, which I have been successfully using for 1.5 working days 2 weeks a while.

I did not use a function for skipping tests like @adisbladis suggested and implemented in https://github.com/adisbladis/nixpkgs/tree/go_1_13, IMO this is out of scope of this PR - consistency is more important here.
I think stylistic/organizational changes belong in #35381

Packages still broken(there might be more):

  • deepin
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @cstrahan @orivej @velovix @Mic92 @kalbasit

@ofborg ofborg bot requested review from velovix, Mic92 and cstrahan September 5, 2019 11:12
@adisbladis
Copy link
Member

@rvolosatovs I did a nox-review on my branch and found the following failures:

 /nix/store/0xaddkf0ma3h0mlny3273icn2g3ixzgk-lnd-0.7.1-beta.drv
  /nix/store/137jp3qyvllfy08z6pvnsxlr6f0w37zg-magnetico-0.8.1.drv
  /nix/store/w16anbv6bcjsfi2jmq3qsf8l4shki2rh-qtwebkit-5.212-alpha-01-26-2018.drv
  /nix/store/ll4nzrllg4hijlpyysp2zx3639607s78-phantomjs-2.1.1.drv
  /nix/store/2dnvggx9qzmbdq147nf8vfy59akd2rk4-grafana-6.3.5.drv
  /nix/store/39xbs03k9qpbxlz4p6g332q69j2r182w-grpcui-0.2.0.drv
  /nix/store/5550hrgpg9xaf7rxz5wx07f5s6rdxpdf-conftest-0.7.0.drv
  /nix/store/5ip41wik25fxsbrha7y54v2h4h6x69c5-vault-1.2.2-go-modules.drv
  /nix/store/6bgchfqk6wh94w7g698kiyiy44r12zdk-lazydocker-0.7.drv
  /nix/store/6d3xh04ma6vykabwphfx26hgfqf4hzim-cue-0.0.3.drv
  /nix/store/6qa5yf2bw16zs0dyjrq35b0fv5jb8l8m-helmfile-0.79.3.drv
  /nix/store/8g4bjj61lz3xy6y2kyhwhi1mmd9xrxsc-bazel-watcher-0.10.3.drv
  /nix/store/8m67bqhh8z4qh71xqf7y2knc84k0dfpc-ctop-0.7.2.drv
  /nix/store/vqyw3sl6al0346kvq7zdhd1p6xxcgv3q-terraform-provider-elasticsearch-0.7.0.drv
  /nix/store/zwqh87wy5aa8xz9x100928qzibw14s7p-tf-plugin-env.drv
  /nix/store/v1zb0437a90y72fmlv3jz8klsf9yxj30-terraform-0.11.14.drv
  /nix/store/bhl5ik1dva2ad2bjvjrqfriyf7dnhfiv-terragrunt-0.17.4.drv
  /nix/store/cnpl55ripjq788bzafn6d76kkh426adq-ghq-0.12.6.drv
  /nix/store/hgga50qy7qmji6ifqp9qwxv82q3wy84q-terraform-lsp-0.0.5.drv
  /nix/store/hmvq28ga6agsignci3mdm9nhvjbnbkwh-prometheus_varnish_exporter-1.5.1.drv
  /nix/store/inkjfbyzkhcb51z4xf5i82k93a2hrh8f-scaleway-cli-1.17.drv
  /nix/store/k2z4p92p9vma8i0d589ws1qx4qvkqpa5-gotestsum-0.3.5.drv
  /nix/store/khfagkcdkygmsjj782zp6s6iw17jw228-curlie-1.2.0.drv
  /nix/store/kngxad53xhiy0cbf2y8aap6y86hdjxr4-prow-unstable-2019-08-14.drv
  /nix/store/lp1a7y4byli5l4zgdsnfbp52npd1np4c-packr-2.5.2.drv
  /nix/store/mhykzrg6r4x2alv8rppngzkqcwxaw417-tendermint-0.32.2.drv
  /nix/store/mq3w6khxlrqpx4yqg4697bz754qla9jg-restic-0.9.5.drv
  /nix/store/ng8f7mizfqpmqzb4phx3qmlvf3zrnq0q-cri-o-1.15.0.drv
  /nix/store/q54c9h6smxg2sxka6ib9qdx4zjddx9fg-openshift-origin-3.11.0.drv
  /nix/store/q57x1sg297v01dw7mk51kmq7ylqmn0ri-wtf-0.21.0.drv
  /nix/store/s4mlrqhdd26f8429chwxhsby652nk76x-git-lfs-2.7.2.drv
  /nix/store/sjmc0hllxzpa6lhalac6wp1y8zfs2l2q-vault-1.2.2.drv
  /nix/store/spf0xv7l7pf18r1ayv2rdngal29c6vrn-cockroach-19.1.1.drv
  /nix/store/x54vx64xkcfrlg46yqp0h82nw8xqq6jc-consul-1.6.0.drv
  /nix/store/x5pfsam5chjzrnx38969sxfpiar4522l-ipfs-0.4.21.drv
  /nix/store/xl2iyn7cznni9ri5zq65v2ydsd9lcfwp-blockbook-0.3.1.drv
  /nix/store/y9bcmy7ycwvr3wnqmdv68fnawv5d4bd5-deepin-wm-1.9.38.drv
  /nix/store/ydbmnf9372y75pa2r94zdmvwq3z99pl8-minishift-1.34.0.drv
  /nix/store/z8jw1w8i61ibggxbj6c772jd6r04s2gz-skydive-0.17.0.drv
  /nix/store/zjv7saninzagsnw6g41jqjg7w95gcys9-eksctl-0.4.3.drv

@adisbladis adisbladis mentioned this pull request Sep 5, 2019
Closed
10 tasks
@rvolosatovs
Copy link
Member Author

Indeed, I see. At least in case of ghq, the package is incompatible with Go 1.13, due to a dependency on xerrors, which in turn is incompatible with Go 1.13
I opened an issue and PR upstream x-motemen/ghq#192 x-motemen/ghq#193
I assume we can mitigate most of the failures by just using the go 1.12 for the builds

@ofborg ofborg bot requested review from kalbasit and sigma September 5, 2019 17:54
@rvolosatovs rvolosatovs changed the title Add Go 1.13 [WIP] Add Go 1.13 Sep 5, 2019
This was referenced Sep 5, 2019
Merged
Merged
@ofborg ofborg bot requested a review from fpletz September 5, 2019 18:19
kalbasit
kalbasit approved these changes Sep 5, 2019
View reviewed changes
pkgs/development/compilers/go/1.13.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from kalbasit September 6, 2019 09:56
@Chiiruno Chiiruno mentioned this pull request Sep 8, 2019
Closed
10 tasks
@rvolosatovs rvolosatovs force-pushed the update/go branch 2 times, most recently from 094d9d9 to d4cb16f Compare September 8, 2019 18:40
@ofborg ofborg bot requested a review from Mic92 September 8, 2019 18:49
@rvolosatovs
Copy link
Member Author

@adisbladis do you have fixes for (any of) packages broken by 1.13 update?
If so, maybe you can open PRs for them or I can cherry-pick them here?

rvolosatovs and others added 24 commits October 11, 2019 10:09
@rvolosatovs
all-packages: use go 1.12 for cri-o
2f20deb
@rvolosatovs
all-packages: use go 1.12 for curlie
db6cb37
@rvolosatovs
all-packages: use go 1.12 for gotestsum
ee2c8ec
@rvolosatovs
all-packages: use go 1.12 for grpcui
745b299
@rvolosatovs
all-packages: use go 1.12 for lnd
7ddd2a2
@rvolosatovs
all-packages: use go 1.12 for scaleway-cli
72a6ab4
@rvolosatovs
all-packages: use go 1.12 for tendermint
b63b95f
@rvolosatovs
all-packages: use go 1.12 for restic
a3341e8
@rvolosatovs
all-packages: use go 1.12 for packr
cf6e277
@rvolosatovs
all-packages: use go 1.12 for terraform-lsp
fcdc280
@rvolosatovs
all-packages: use go 1.12 for terraform-providers.elasticsearch
8c33df9
@rvolosatovs
all-packages: use go 1.12 for prow
e45055c
@c00w @rvolosatovs
all-packages: use go 1.12 for cockroachdb
eec1a13
@c00w @rvolosatovs
all-packages: use go 1.12 for grafana
6e031f1
@c00w @rvolosatovs
all-packages: use go 1.12 for magnetico
7c6e987 
Co-authored-by: Roman Volosatovs <rvolosatovs@riseup.net>
@c00w @rvolosatovs
all-packages: use go 1.12 for openshift
057b547
@c00w @rvolosatovs
all-packages: use go 1.12 for kubernetes
e9a9b55
@marsam @rvolosatovs
documize-community: disable go module build
88ffdab
@c00w @rvolosatovs
all-packages: use go 1.12 for prometheus and prometheus-varnish-exporter
fc5026b 
These both fail to work with go1.13 due to test issues, downgrading to
1.12
@c00w @rvolosatovs
all-packages: use go 1.12 for circleci-cli
d32980c
@c00w @rvolosatovs
all-packages: use go 1.12 for git-lfs
52d057f
@rvolosatovs
go_1_13: add kalbasit to maintainers
f93ea5a
@c00w @rvolosatovs
conftest: 0.12.0 -> 0.14.0, disable go sum db.
88f65fc 
The go sum db is a hosted service that appears to be generating a new
inclusion proof each time this build is run (rather than using the one
from the previous run). Since this ends up the module directory + thus
hash, it's breaking deterministic builds.

Co-authored-by: Roman Volosatovs <rvolosatovs@riseup.net>
@c00w @rvolosatovs
gcsfuse: add go.mod and go.sum files.
8ff1865 
It looks like go1.12 silently created the module, but go1.13 does not.
@rvolosatovs
Copy link
Member Author

Cherry-picked c00w@f49b872 and rebased on top of latest master. Should be good to go.

@kalbasit yes, didn't want things like #68135 (comment) happen again

@kalbasit
Copy link
Member

@GrahamcOfBorg build gcsfuse jx pet

@kalbasit kalbasit merged commit 62e894b into NixOS:master Oct 12, 2019
@rvolosatovs rvolosatovs deleted the update/go branch October 12, 2019 14:02
@c00w c00w mentioned this pull request Oct 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngerstle-cognite ngerstle-cognite ngerstle-cognite left review comments

@kalbasit kalbasit kalbasit approved these changes

@c00w c00w c00w approved these changes

@velovix velovix Awaiting requested review from velovix

@cstrahan cstrahan Awaiting requested review from cstrahan

@sigma sigma Awaiting requested review from sigma

@fpletz fpletz Awaiting requested review from fpletz

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@yurrriq yurrriq Awaiting requested review from yurrriq

@apeyroux apeyroux Awaiting requested review from apeyroux

@sauyon sauyon Awaiting requested review from sauyon

@marsam marsam Awaiting requested review from marsam

Assignees

@kalbasit kalbasit

Labels
6.topic: golang 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+ 11.by: package-maintainer
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet