Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WACK error for square 44x44 logo asset #24156

Closed
jdm opened this issue Sep 6, 2019 · 2 comments · Fixed by #24177
Closed

WACK error for square 44x44 logo asset #24156

jdm opened this issue Sep 6, 2019 · 2 comments · Fixed by #24177
Labels
P-windows Any version of Windows capable of running Servo
Projects
UWP port

Comments

@jdm
Copy link
Member

jdm commented Sep 6, 2019

There is one remaining asset error reported by the Windows App Certification Kit:

Image file Square44x44Logo.targetsize-24_altform-unplated.png is a default image.

cc @paulrouget
@jdm jdm added the P-windows Any version of Windows capable of running Servo label Sep 6, 2019
@jdm jdm added this to To do in UWP port via automation Sep 6, 2019
@paulrouget
Copy link
Contributor

Unplated icons are optional: https://docs.microsoft.com/en-us/windows/uwp/design/style/app-icons-and-logos#unplated-assets

I'll remove them.

@paulrouget paulrouget mentioned this issue Sep 10, 2019
Closed
@paulrouget
Copy link
Contributor

I'll remove them

Never mind. Without the unplated, on Desktop, the icon has a double padding. I'll keep them and fix the logo.

@paulrouget paulrouget mentioned this issue Sep 11, 2019
Merged
@jdm jdm moved this from To do to In progress in UWP port Sep 11, 2019
UWP port automation moved this from In progress to Done Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-windows Any version of Windows capable of running Servo
Projects
No open projects
UWP port
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix UWP icons paulrouget/servo
2 participants
@jdm @paulrouget