[WPT/common/security-features] Update subresource and redirection type names #18906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e names This CL removes `redirectionTypeConversion` and `subresourceTypeConversion`, and uses the new names directly in `common.sub.js`. Bug: 906850 Change-Id: I634d29ffca00180b05af38fb312c0fdeebf25776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788544 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#694153}
wpt-pr-bot
approved these changes
Sep 6, 2019
|
Timing out just because of a large number of affected tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL removes
redirectionTypeConversionandsubresourceTypeConversion, and uses the new names directly incommon.sub.js.Bug: 906850
Change-Id: I634d29ffca00180b05af38fb312c0fdeebf25776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788544
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694153}