Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radeontool: 1.5 -> 1.6.3 #68220

Merged
merged 1 commit into from Sep 24, 2019
Merged

radeontool: 1.5 -> 1.6.3 #68220

merged 1 commit into from Sep 24, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 6, 2019 •
edited

Motivation for this change

fixing broken @ryantm updates

I don't have a radeon card, so i couldn't fully test, but the binaries are properly linked and seem to work.

Essentally followed the archlinux build https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/radeontool

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

# was broken before
$ nix path-info -Sh ./result
/nix/store/5mcnbpfg7ivlfrq24vagqgg4l88g31zy-radeontool-1.6.3      27.2M

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68220
1 package were build:
radeontools

@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
ck3d
ck3d approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@ck3d ck3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the tool successfully with my Radeon.

@Mic92 Mic92 merged commit 43c6c75 into NixOS:master Sep 24, 2019
@jonringer jonringer deleted the bump-radeontool branch September 24, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ck3d ck3d ck3d approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonringer @ck3d @Mic92 @lheckemann