Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPT/common/security-features] Remove {mixed-content,referrer-policy}-test-case.sub.js #18905

Merged
merged 1 commit into from Sep 9, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

This CL merges getSubresourceOrigin() from *test-case.js into common.sub.js.

This removes the dependency from common.sub.js to *test-case.js.
Previously, some manually-written tests includes
\<script src=referrer-policy-test-case.sub.js>
because of this dependency, and now we can remove such \<script>s.

After then, no scripts uses {mixed-content,referrer-policy}-test-case.sub.js
and this CL removes them.

Bug: 906850
Change-Id: I93acf8477037276e0a0289afabbbdc7a484734f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787166
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694150}

…-test-case.sub.js

This CL merges getSubresourceOrigin() from *test-case.js into `common.sub.js`.

This removes the dependency from `common.sub.js` to *test-case.js.
Previously, some manually-written tests includes
`<script src=referrer-policy-test-case.sub.js>`
because of this dependency, and now we can remove such `<script>`s.

After then, no scripts uses {mixed-content,referrer-policy}-test-case.sub.js
and this CL removes them.

Bug: 906850
Change-Id: I93acf8477037276e0a0289afabbbdc7a484734f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787166
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694150}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants