Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luarocks: 3.1.3 -> 3.2.1 #68201

Merged
merged 1 commit into from Sep 7, 2019
Merged

luarocks: 3.1.3 -> 3.2.1 #68201

merged 1 commit into from Sep 7, 2019

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Sep 6, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Another small change:

Switched to fetchFromGitHub since from some reason this release is not available here: https://luarocks.github.io/luarocks/releases/ but it does on GitHub's releases.

Notify maintainers

cc @teto @raskin

@ofborg ofborg bot requested review from teto and 7c6f434c September 6, 2019 11:47
7c6f434c
7c6f434c approved these changes Sep 6, 2019
View reviewed changes
Copy link
Member

@7c6f434c 7c6f434c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to break neovim or lua-zlib or luaffi build.

@teto
Copy link
Member

teto commented Sep 7, 2019

What's your motivation for bumping it ? I've asked luarocks on gitter for a changelog. waiting :)

@teto teto mentioned this pull request Sep 7, 2019
Closed
@teto
Copy link
Member

teto commented Sep 7, 2019

@GrahamcOfBorg build luaPackages.nvim-client lua52Packages.nvim-client lua52Packages.cjson luaPackages.lpeg

@teto teto mentioned this pull request Sep 7, 2019
Merged
10 tasks
@teto teto merged commit 18b783b into NixOS:master Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

@7c6f434c 7c6f434c 7c6f434c approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @teto @7c6f434c