Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lilypond: fix segfault #68127

Merged
merged 1 commit into from Sep 7, 2019
Merged

Conversation

jasom
Copy link
Contributor

@jasom jasom commented Sep 5, 2019

When built with GCC>=6.0 current stable lilypond requires
-fno-delete-null-pointer or it may segfault.

Unstable lilypond no longer relies on "this" being allowed to be null, so does
not need this change.

Upstream bug: https://sourceforge.net/p/testlilyissues/issues/4814/

Sample input to reproduce issue:

\version "2.18.2"

\new Staff {
    f8( e~ e2.) |
}
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

When built with GCC>=6.0 current stable lilypond requires
-fno-delete-null-pointer or it may segfault.

Unstable lilypond no longer relies on "this" being allowed to be null, so does
not need this change.

Upstream bug: https://sourceforge.net/p/testlilyissues/issues/4814/

Sample input to reproduce issue:

```
\version "2.18.2"

\new Staff {
    f8( e~ e2.) |
}
```
@ryantm ryantm merged commit 6751e49 into NixOS:staging-19.03 Sep 7, 2019
@ryantm
Copy link
Member

ryantm commented Sep 7, 2019

Thanks!

@FRidh
Copy link
Member

FRidh commented Sep 7, 2019

Why 19.03 and why staging there? Typically fixes go via master first and are cherry-picked to release branches.

@ryantm
Copy link
Member

ryantm commented Sep 8, 2019

@FRidh Dang, I missed the target branch. Should I revert it?

@FRidh
Copy link
Member

FRidh commented Sep 8, 2019

You could cherry-pick it to master. @jasom which branch did you intend this for?

@jasom
Copy link
Contributor Author

jasom commented Sep 9, 2019

@FRidh sorry, should be against master; I didn't read https://nixos.org/nixpkgs/manual/#submitting-changes-making-patches thoroughly enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants