Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.{colorcet,pytest-mpl}: fix & re-enable all tests on darwin #68260

Merged
merged 2 commits into from
Sep 7, 2019
Merged

pythonPackages.{colorcet,pytest-mpl}: fix & re-enable all tests on darwin #68260

merged 2 commits into from
Sep 7, 2019
+3 −5

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 7, 2019

Motivation for this change

The matplotlib backend: ps trick does indeed work for macos too, but matplotlib just looks for the the dotfile under ~/.matplotlib instead. So add a symlink.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @marsam

Sorry, something went wrong.

@risicle
pythonPackages.colorcet: fix & enable all tests on darwin

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: F3510FE5691629A1
Learn about vigilant mode
daebef5 
dotfile is simply in a different place on macos
@risicle
pythonPackages.pytest-mpl: fix & enable tests on darwin

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: F3510FE5691629A1
Learn about vigilant mode
5e0ec5a 
dotfile is simply in a different place on macos
@risicle risicle requested a review from FRidh as a code owner September 7, 2019 12:44
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: python labels Sep 7, 2019
@ofborg ofborg bot requested a review from costrouc September 7, 2019 12:58
@marsam marsam merged commit 925501a into NixOS:master Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam

@FRidh FRidh

@costrouc costrouc

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @marsam