Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit packaging step for UWP apps #24149

Merged
merged 1 commit into from Sep 17, 2019
Merged

Add explicit packaging step for UWP apps #24149

merged 1 commit into from Sep 17, 2019

Conversation

jdm
Copy link
Member

@jdm jdm commented Sep 5, 2019 •
edited by SimonSapin

This change is Reviewable

@highfive
Copy link

highfive commented Sep 5, 2019

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/servo/command_base.py, python/servo/build_commands.py, python/servo/package_commands.py

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 5, 2019
@jdm jdm removed the S-awaiting-review There is new code that needs to be reviewed. label Sep 5, 2019
@jdm
Copy link
Member Author

jdm commented Sep 5, 2019

@bors-servo try=windows

@bors-servo
Copy link
Contributor

⌛ Trying commit 7b75f59 with merge ce52670...

bors-servo pushed a commit that referenced this pull request Sep 5, 2019
Auto merge of #24149 - jdm:opt-in-msbuild, r=<try>
ce52670 
[WIP] Opt in msbuild

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24149)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Sep 5, 2019
@jdm
Copy link
Member Author

jdm commented Sep 5, 2019

@bors-servo try=windows

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 5, 2019
@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #24140) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Sep 6, 2019
@jdm
Copy link
Member Author

jdm commented Sep 6, 2019

@bors-servo try=windows

@bors-servo
Copy link
Contributor

⌛ Trying commit eb01f4f with merge 3f3e0ed...

bors-servo pushed a commit that referenced this pull request Sep 6, 2019
Auto merge of #24149 - jdm:opt-in-msbuild, r=<try>
3f3e0ed 
[WIP] Opt in msbuild

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24149)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 6, 2019
@jdm
Copy link
Member Author

jdm commented Sep 6, 2019

@bors-servo try=windows

@bors-servo
Copy link
Contributor

⌛ Trying commit 727f78c with merge 4b1d9fc...

bors-servo pushed a commit that referenced this pull request Sep 6, 2019
Auto merge of #24149 - jdm:opt-in-msbuild, r=<try>
4b1d9fc 
[WIP] Opt in msbuild

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24149)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 6, 2019
@jdm
Copy link
Member Author

jdm commented Sep 6, 2019

@bors-servo try=windows

@jdm
Copy link
Member Author

jdm commented Sep 12, 2019

@bors-servo try=windows

@jdm jdm closed this Sep 12, 2019
@jdm jdm reopened this Sep 12, 2019
bors-servo pushed a commit that referenced this pull request Sep 12, 2019
Auto merge of #24149 - jdm:opt-in-msbuild, r=<try>
911aa6a 
[WIP] Opt in msbuild

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24149)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

⌛ Trying commit db0f49b with merge 911aa6a...

@jdm jdm changed the title [WIP] Opt in msbuild Add explicit packaging step for UWP apps Sep 12, 2019
@jdm
Copy link
Member Author

jdm commented Sep 13, 2019

r? @SimonSapin

@jdm jdm closed this Sep 13, 2019
@jdm jdm reopened this Sep 13, 2019
@jdm jdm removed the S-needs-rebase There are merge conflict errors. label Sep 13, 2019
@bors-servo
Copy link
Contributor

💥 Test timed out

@jdm
Copy link
Member Author

jdm commented Sep 16, 2019

r? @paulrouget

@highfive highfive assigned paulrouget and unassigned SimonSapin Sep 16, 2019
@jdm
Copy link
Member Author

jdm commented Sep 16, 2019

This will give us appxbundle artifacts from the CI builds for every PR, as well as nightly combined appxbundles for arm64 and x64.

@paulrouget
Copy link
Contributor

Amazing!

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit c1f9dfd has been approved by paulrouget

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Sep 17, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit c1f9dfd with merge 8bc8981...

bors-servo pushed a commit that referenced this pull request Sep 17, 2019
Auto merge of #24149 - jdm:opt-in-msbuild, r=paulrouget
8bc8981 
Add explicit packaging step for UWP apps

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24149)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: paulrouget
Pushing 8bc8981 to master...

@bors-servo bors-servo merged commit c1f9dfd into servo:master Sep 17, 2019
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 17, 2019
@bors-servo bors-servo mentioned this pull request Sep 17, 2019
Closed
5 tasks
This was referenced Sep 17, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@paulrouget paulrouget

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jdm @highfive @bors-servo @paulrouget @SimonSapin