Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unsupported go versions 1.10 and 1.11 #68176

Closed
wants to merge 17 commits into from
Closed

Drop unsupported go versions 1.10 and 1.11 #68176

wants to merge 17 commits into from

Conversation

adisbladis
Copy link
Member

Motivation for this change

These versions are no longer supported by upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

Can maintainers of packages marked as broken fix your respective packages in a separate PR and reference this PR so I can drop those commits setting broken = true?
cc @fpletz @nlewo

Also CCing the contributors who latest updated those packages:
@volth @kamilchm

I'd like a solution to all filebeats version using pinned old compiler versions, they are currently the only thing left in the tree referencing buildGo111Package.
CC beats maintainers @fadenb @basvandijk

CCing Go maintainers
@cstrahan @orivej @velovix @Mic92

@adisbladis
perkeep: 0.10.1 -> unstable-2019-07-29
a7dfe3f 
0.10.1 is the latest release but it doesn't build with recent go versions
@adisbladis
go-ethereum-classic: Drop package
7814d35 
It's unmaintained for years and doesn't build with Go 1.12
@adisbladis
fscrypt: 0.2.4 -> unstable-2019-08-29
aeef53e 
Fix build with go 1.12
@adisbladis
prometheus-snmp-exporter: 0.13.0 -> 0.15.0
a560ea3
@adisbladis
prometheus_1: Build with go 1.12
3c22b23
@adisbladis
diskrsync: unstable-2018-02-03 -> unstable-2019-01-02
2ff836f
@adisbladis
goa: Build with go 1.12
7e8573b
@adisbladis
dnscrypt-proxy2: Build with go 1.12
f942702
@adisbladis
ipget: Build with go 1.12
416d11b
@adisbladis
notary: Build with go 1.12
4bca8b4
@adisbladis
meguca: Build with go 1.12
137f947
@adisbladis
tmsu: Build with go 1.12
538a27b
@adisbladis
go_1_10: Drop package
b611485 
It's unsupported by upstream.
@adisbladis
skydive: Mark as broken
aec30a2 
Does not build with go 1.12
@adisbladis
mirrorbits: Mark as broken
f15abc5 
Does not build with go 1.12
@adisbladis
mongodb-tools: Mark as broken
e9cf19d 
Does not build with go 1.12
@adisbladis
go_1_11: Drop package
a817cda 
It's unsupported
@adisbladis
Copy link
Member Author

I'm going to split this into two PRs: One handling Go 1.10 and one handling Go 1.11.

@adisbladis adisbladis closed this Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: golang
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@adisbladis