Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 7d3b44c9be00
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 1ede2de8a3c3
Choose a head ref
  • 9 commits
  • 32 files changed
  • 1 contributor

Commits on Sep 6, 2019

  1. Split buildPythonPackage into setup hooks 

    This commit splits the `buildPythonPackage` into multiple setup hooks.

Generally, Python packages are built from source to wheels using `setuptools`.
The wheels are then installed with `pip`. Tests were often called with
`python setup.py test` but this is less common nowadays. Most projects
now use a different entry point for running tests, typically `pytest`
or `nosetests`.

Since the wheel format was introduced more tools were built to generate these,
e.g. `flit`. Since PEP 517 is provisionally accepted, defining a build-system
independent format (`pyproject.toml`), `pip` can now use that format to
execute the correct build-system.

In the past I've added support for PEP 517 (`pyproject`) to the Python
builder, resulting in a now rather large builder. Furthermore, it was not possible
to reuse components elsewhere. Therefore, the builder is now split into multiple
setup hooks.

The `setuptoolsCheckHook` is included now by default but in time it should
be removed from `buildPythonPackage` to make it easier to use another hook
(curently one has to pass in `dontUseSetuptoolsCheck`).
    @FRidh
    FRidh committed Sep 6, 2019
    Copy the full SHA
    f7e28bf View commit details
    Browse the repository at this point in the history

  2. pythonPackages.tld: use pythonImportsCheck and pytestCheckHook

    @FRidh
    FRidh committed Sep 6, 2019
    Copy the full SHA
    9dd6537 View commit details
    Browse the repository at this point in the history

  3. python.pkgs.terminado: disable tests

    @FRidh
    FRidh committed Sep 6, 2019
    Copy the full SHA
    755de1c View commit details
    Browse the repository at this point in the history

  4. python: bootstrapped-pip: update wheel, setuptools, pip 

    wheel 33.4 -> 33.6
setuptools 41.0.1 -> 42.2.0
pip 19.1.1 -> 19.2.3
    @FRidh
    FRidh committed Sep 6, 2019
    Copy the full SHA
    dc95e17 View commit details
    Browse the repository at this point in the history

  5. python.pkgs.pip: 19.1.1 -> 19.2.3

    @FRidh
    FRidh committed Sep 6, 2019
    Copy the full SHA
    afe67e5 View commit details
    Browse the repository at this point in the history

  6. python.pkgs.setuptools: 0.33.4 -> 0.33.6

    @FRidh
    FRidh committed Sep 6, 2019
    Copy the full SHA
    0570a6b View commit details
    Browse the repository at this point in the history

  7. python.pkgs.wheel: 0.33.4 -> 0.33.6

    @FRidh
    FRidh committed Sep 6, 2019
    Copy the full SHA
    5718ed6 View commit details
    Browse the repository at this point in the history

  8. pythonPackages.editorconfig: remove duplicate EditorConfig

    @FRidh
    FRidh committed Sep 6, 2019
    Copy the full SHA
    bf4f885 View commit details
    Browse the repository at this point in the history

  9. pythonPackages.editorconfig: -> 0.12.1 -> 0.12.2

    @FRidh
    FRidh committed Sep 6, 2019
    Copy the full SHA
    1ede2de View commit details
    Browse the repository at this point in the history