Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: google-auth: fix usage of pytest.warns in tests #68163

Merged
merged 1 commit into from Sep 6, 2019
Merged

python: google-auth: fix usage of pytest.warns in tests #68163

merged 1 commit into from Sep 6, 2019

Conversation

AluisioASG
Copy link
Contributor

Motivation for this change

This (and dependent packages) broke on Python 3 after b3ddab8. Tests still work on Python 2 with pytest 4.6.5.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vanschelven

This was referenced Sep 5, 2019
Merged
Merged
@ofborg ofborg bot requested a review from vanschelven September 5, 2019 19:27
@FRidh
Copy link
Member

FRidh commented Sep 6, 2019

Could we fetch the patch instead?

@AluisioASG
Copy link
Contributor Author

Sure, done. Also changed the commit message to reflect the intent of the patch.

@FRidh FRidh merged commit e030351 into NixOS:master Sep 6, 2019
@AluisioASG AluisioASG deleted the aasg/fix-google-auth-test branch September 7, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@vanschelven vanschelven Awaiting requested review from vanschelven

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AluisioASG @FRidh