wtf: Add infocmp to PATH, fixes #68103
#68134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avdv
force-pushed
the
wtf-add-infocmp
branch
from
e52110e
to
b170193
Compare
avdv
commented
Sep 5, 2019
| @@ -27,6 +31,10 @@ buildGoModule rec { | |||
| runHook postBuild | |||
| ''; | |||
|
|
|||
| postInstall = '' | |||
| wrapProgram "$out/bin/wtf" --prefix PATH : "${ncurses.dev}/bin" | |||
There was a problem hiding this comment.
Is this good style or should one better use stdenv.lib.makeBinPath?
There was a problem hiding this comment.
LGTM. makeBinPath is only helpful when you are adding many packages to the PATH.
kalbasit
approved these changes
Sep 5, 2019
| @@ -27,6 +31,10 @@ buildGoModule rec { | |||
| runHook postBuild | |||
| ''; | |||
|
|
|||
| postInstall = '' | |||
| wrapProgram "$out/bin/wtf" --prefix PATH : "${ncurses.dev}/bin" | |||
There was a problem hiding this comment.
LGTM. makeBinPath is only helpful when you are adding many packages to the PATH.
|
@GrahamcOfBorg build wtf |
|
Thanks @avdv |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
wtfdoes not run on some terminals out of the box, see issue #68103.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @kalbasit