CSS: counter-reset/increment inherit clears old values #18915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we update 'counter-increment' or 'counter-reset' to 'inherit',
we now overwrite the previously resolved values, instead of
merging in the parent values.
Existing Blink fails test with
FAIL Inheritance of counter-reset replaces existing value assert_equals: expected "first 1" but got "first 1 fourth 4"
FAIL Inheritance of counter-increment replaces existing value assert_equals: expected "second 2" but got "second 2 fifth 5"
Existing Safari fails test with
FAIL Inheritance of counter-reset replaces existing value assert_equals: expected "second 0 first 1" but got "second 0 fifth 0 first 1"
FAIL Inheritance of counter-increment replaces existing value assert_equals: expected "second 2 first 0" but got "second 2 fourth 0 first 0"
Bug: 1001776
Change-Id: Ic7279a84f022f0bc156bdab1a044b3403cb2c7ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789213
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695094}