Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: counter-reset/increment inherit clears old values #18915

Merged
merged 1 commit into from Sep 10, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 7, 2019

When we update 'counter-increment' or 'counter-reset' to 'inherit',
we now overwrite the previously resolved values, instead of
merging in the parent values.

Existing Blink fails test with
FAIL Inheritance of counter-reset replaces existing value assert_equals: expected "first 1" but got "first 1 fourth 4"
FAIL Inheritance of counter-increment replaces existing value assert_equals: expected "second 2" but got "second 2 fifth 5"

Existing Safari fails test with
FAIL Inheritance of counter-reset replaces existing value assert_equals: expected "second 0 first 1" but got "second 0 fifth 0 first 1"
FAIL Inheritance of counter-increment replaces existing value assert_equals: expected "second 2 first 0" but got "second 2 fourth 0 first 0"

Bug: 1001776
Change-Id: Ic7279a84f022f0bc156bdab1a044b3403cb2c7ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789213
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695094}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

When we update 'counter-increment' or 'counter-reset' to 'inherit',
we now overwrite the previously resolved values, instead of
merging in the parent values.

Existing Blink fails test with
FAIL Inheritance of counter-reset replaces existing value assert_equals: expected "first 1" but got "first 1 fourth 4"
FAIL Inheritance of counter-increment replaces existing value assert_equals: expected "second 2" but got "second 2 fifth 5"

Existing Safari fails test with
FAIL Inheritance of counter-reset replaces existing value assert_equals: expected "second 0 first 1" but got "second 0 fifth 0 first 1"
FAIL Inheritance of counter-increment replaces existing value assert_equals: expected "second 2 first 0" but got "second 2 fourth 0 first 0"

Bug: 1001776
Change-Id: Ic7279a84f022f0bc156bdab1a044b3403cb2c7ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789213
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695094}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants