Move forced colors tests to wpt #18907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 6, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1789923
branch
from
dd947b5
to
dd53a97
Compare
This change moves forced colors web tests to external/wpt. Having separate reference files in wpt is not possible, so the tests are written assuming the virtual flags are used, with the expectation that the tests will fail in the non-virtual case. Tests that used layout test APIs, such as testRunner and internals, were not able to be moved to external/wpt and remain in fast/css. Bug: 970285 Change-Id: Id7410f7d4e9f009e848807b811611051320f23ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789923 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#694796}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1789923
branch
from
dd53a97
to
4780e4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves forced colors web tests to external/wpt. Having
separate reference files in wpt is not possible, so the tests are
written assuming the virtual flags are used, with the expectation
that the tests will fail in the non-virtual case.
Tests that used layout test APIs, such as testRunner and internals,
were not able to be moved to external/wpt and remain in fast/css.
Bug: 970285
Change-Id: Id7410f7d4e9f009e848807b811611051320f23ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789923
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694796}