Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove prometheus 1 #68221

Merged
merged 3 commits into from Sep 6, 2019
Merged

remove prometheus 1 #68221

merged 3 commits into from Sep 6, 2019

Conversation

WilliButz
Copy link
Member

Motivation for this change

Prometheus 1 is no longer developed and should not be used anymore.

Things done

The package prometheus_1 was removed, prometheus_2 is now called prometheus and I added myself as maintainer for it.
The module services.prometheus2 now takes services.prometheus's place, allowing for an easy transition of users with an existing Prometheus 2 setup. With this approach Prometheus 1 users might either run into evaluaton errors or just end up with a fresh Prometheus 2 database next to their old Prometheus 1 database. In a szenario where they did not read the release notes before upgrading, this should not cause data loss with the default module configuration but might be an unpleasant (however still long overdue) transition.
The test for Prometheus 1 is now obsolete, so the one for Prometheus 2 takes its place.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @fpletz, @basvandijk, @lheckemann, @disassembler

As prometheus is no longer developed, nixpkgs now only includes
prometheus 2. Having only one version of prometheus, there is no need
for having the version in the attribute name.
Prometheus 1 is no longer supported, instead 'services.prometheus'
now configures the Prometheus 2 service.
Copy link
Member

@lheckemann lheckemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release notes and the concept LGTM, can't say much about the functional contents since I'm totally unfamiliar with prometheus and its module.

@WilliButz
Copy link
Member Author

@GrahamcOfBorg test prometheus

Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned on the PR that added support for version 2, I welcome the removal of prometheus 1. The implementation LGTM.

@lheckemann lheckemann merged commit cfe51be into NixOS:master Sep 6, 2019
@WilliButz WilliButz deleted the remove-prometheus1 branch September 6, 2019 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants