Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Prometheus 1 is no longer developed and should not be used anymore.
Things done
The package
prometheus_1
was removed,prometheus_2
is now calledprometheus
and I added myself as maintainer for it.The module
services.prometheus2
now takesservices.prometheus
's place, allowing for an easy transition of users with an existing Prometheus 2 setup. With this approach Prometheus 1 users might either run into evaluaton errors or just end up with a fresh Prometheus 2 database next to their old Prometheus 1 database. In a szenario where they did not read the release notes before upgrading, this should not cause data loss with the default module configuration but might be an unpleasant (however still long overdue) transition.The test for Prometheus 1 is now obsolete, so the one for Prometheus 2 takes its place.
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)cc @fpletz, @basvandijk, @lheckemann, @disassembler