linux-kernel: HID_BATTERY_STRENGTH=yes #68149
Conversation
|
Looks very useful to me. Switching my system to it currently, did you build all kernels as described in the file above? |
There was a problem hiding this comment.
What I checked:
- The lower bounds checked for in common-config is 3.10
- The lower version kernel in nixpkgs is 4.4
- The option was introduced in 3.3
So there's no needs AFAIK to gate the option under a condition.
I am currently building 4.4 and a couple other kernels to see if they all build correctly.
nix-review pr 68149 -p linux_4_4 -p linux_4_9 -p linux_5_2 -p linux_hardkernel_4_14
Will merge if they all build correctly.
nix eval '(with import ./. {}; builtins.map (attr: pkgs."${attr}".version) (builtins.filter (lib.strings.hasPrefix "linux_") (builtins.attrNames pkgs)))'
[ "4.14.141" "4.19.69" "4.4.190" "4.9.190" "5.2.11" "4.19.69" "4.14.120-160" "4.14.120-160" "5.2.11" "5.2.11" "5.2.11" "4.19.55-mptcp_v0.95" "4.14.127-mptcp_v0.94.6" "4.19.55-mptcp_v0.95" "4.14.98-1.20190215" "5.2-rc7" "5.1.2019.08.21" "5.2-rc7" ]
|
Thanks! It seems my bluetooth speakers only expose their battery status when in HFP mode, and I couldn't get pulseaudio to switch to it due to https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/122, so I can't test battery status appearing |
|
BTW, I merged it, leaving the target branch to staging, but this was a bit on the cusp of what should be going into staging, and what shouldn't. In my opinion this would have been fine on master. Why is this important now? Because of the 19.09 fork. What I propose is to backport the change in 19.09 as soon as convenient, @lheckemann, @disassembler do you see any reason not to? |
|
I agree - we shouldn't wait another half a year for bluetooth battery status information to reach users on stable ;-) |
|
👍 for backporting. |
|
Turns out it's already in 19.09, no need to backport it. |
Fixed #68143 by enabling HID_BATTERY_STRENGTH. See the issue and linked reddit thread for more details.
I'm still building my system right now, so I'm not sure if this is good to go yet. Also, I'd like feedback on if there's a better place to add this line.