Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rstudio: fix build with new hunspell-dicts #68146

Merged
merged 1 commit into from Sep 10, 2019

Conversation

averelld
Copy link
Contributor

@averelld averelld commented Sep 5, 2019

Motivation for this change

rstudio build broken because of new hunspell dicts: #66670 (comment)
Not exactly elegant, so improvements welcome.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ivan
Copy link
Member

ivan commented Sep 7, 2019

@GrahamcOfBorg build rstudio rstudioWrapper

@matthewbauer
Copy link
Member

Sorry about that! I didn't realized it would break this. Looked through for other cases of this, and this appears to be the only one.

Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, assuming grahamcofborg says this builds

@devhell
Copy link
Contributor

devhell commented Sep 7, 2019

Thanks for looking into getting this merged, much appreciated! :)

@devhell
Copy link
Contributor

devhell commented Sep 8, 2019

Okay, so I'm not sure why ofBorg had issues, but I can build this locally without errors and rstudio runs.

@ivan
Copy link
Member

ivan commented Sep 8, 2019

I confirm that this PR does build (tested NixOS x86_64).

@devhell
Copy link
Contributor

devhell commented Sep 9, 2019

Thanks, can someone please merge this? @matthewbauer maybe? Thank you!

@lheckemann lheckemann merged commit f024caa into NixOS:master Sep 10, 2019
@lheckemann
Copy link
Member

Backporting to 19.09 as soon as I've built it.

@averelld averelld deleted the rstudio-build-fix branch September 10, 2019 12:34
@lheckemann
Copy link
Member

19.09: ada07de

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants