New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chromium: expose pepperFlash version option #68148
Conversation
Is there a use-case for running any other version of flash, than adobe's latest? If not, I'd rather not build an escape hatch here, but have flashplayer kept up to date in supported releases. I think a better approach would be to join npapi - flashplayer (from mozilla) and ppapi - flashplayer (from chromium) into a single top-level derivation:
|
@bendlas I don't have a use-case for anything but latest Flash (although, heaven's defend them, someone might e.g. for development). But Adobe releases new versions (and yanks the immediately previous one) on their own schedule, which means that until there is an override somewhere, nixpkgs will be able to install Flash only some of the time. As to joining them into a single derivation - how would that work? The two plugins come from different sources and have different hashes. Moving the ppapi one to a simple top-level derivation, however, makes complete sense to me. Should we do that? |
That's my point exactly. If you were to update your own flashplayer, it should be done in a way that your whole system profits, not just chromium. Hence, the flash should go through pkgs, so that it can be updated via regular packageOverride.
I'm envisioning a single
I'd say: go for it. We can still do something about npapi later. |
Thank you for your contributions.
|
This is still important to me, I would prefer that some kind of flashplayer cache be added or used but in lieu of that having the version exposed would help greatly. |
|
Motivation for this change
I wanted to get pepperFlash working with Chromium, but the version in 19.03 is no longer available - old versions are removed very quickly upstream. I pulled the Chromium package into an overlay and set it up this way so that I could update the flash version easily in the face of future upstream updates. With this change applied, it's possible to:
in order to update flash.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Chromium from 19.03 works with this change, but I have not tried it from master.
Notify maintainers
cc @bendlas @ivan