Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: expose pepperFlash version option #68148

Closed
wants to merge 1 commit into from

Conversation

nyarly
Copy link
Contributor

@nyarly nyarly commented Sep 5, 2019

Motivation for this change

I wanted to get pepperFlash working with Chromium, but the version in 19.03 is no longer available - old versions are removed very quickly upstream. I pulled the Chromium package into an overlay and set it up this way so that I could update the flash version easily in the face of future upstream updates. With this change applied, it's possible to:

  nixpkgs.config.chromium = {
    enablePepperFlash = true;
    pepperFlashVersion = "...";
    pepperFlashSHA = "...";
  };

in order to update flash.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • [?] Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Chromium from 19.03 works with this change, but I have not tried it from master.

Notify maintainers

cc @bendlas @ivan

@bendlas
Copy link
Contributor

bendlas commented Sep 14, 2019

Is there a use-case for running any other version of flash, than adobe's latest? If not, I'd rather not build an escape hatch here, but have flashplayer kept up to date in supported releases.

I think a better approach would be to join npapi - flashplayer (from mozilla) and ppapi - flashplayer (from chromium) into a single top-level derivation:

  • This would join forces to keep flashplayer updated
  • Overriding the version (like in this PR) could then be done by package overrides

@nyarly
Copy link
Contributor Author

nyarly commented Oct 9, 2019

@bendlas I don't have a use-case for anything but latest Flash (although, heaven's defend them, someone might e.g. for development). But Adobe releases new versions (and yanks the immediately previous one) on their own schedule, which means that until there is an override somewhere, nixpkgs will be able to install Flash only some of the time.

As to joining them into a single derivation - how would that work? The two plugins come from different sources and have different hashes.

Moving the ppapi one to a simple top-level derivation, however, makes complete sense to me. Should we do that?

@bendlas
Copy link
Contributor

bendlas commented Oct 10, 2019

I don't have a use-case for anything but latest Flash (although, heaven's defend them, someone might e.g. for development).

That's my point exactly. If you were to update your own flashplayer, it should be done in a way that your whole system profits, not just chromium. Hence, the flash should go through pkgs, so that it can be updated via regular packageOverride.

As to joining them into a single derivation - how would that work?

I'm envisioning a single version attribute, that would control both npapi and ppapi flash, since, as you say, both versions are simultaneously released by adobe. Two separate hashes, yes. Ideally, it would come with an update script, writing version info to a json file, and/or be able to be updated by bot.
That said, it should still be two separate derviations (since FF doesn't care about ppapi and vice versa), but we should maximise the chances of somebody updating npapi also updating ppapi.

Moving the ppapi one to a simple top-level derivation, however, makes complete sense to me. Should we do that?

I'd say: go for it. We can still do something about npapi later.

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@rileyinman
Copy link
Contributor

This is still important to me, I would prefer that some kind of flashplayer cache be added or used but in lieu of that having the version exposed would help greatly.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 6, 2020
@taku0
Copy link
Contributor

taku0 commented Feb 13, 2021

flashplayer is deprecated.

@taku0 taku0 closed this Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants