Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drone: 0.8.6 -> 1.3.1 #68271

Merged
merged 1 commit into from Oct 6, 2019
Merged

drone: 0.8.6 -> 1.3.1 #68271

merged 1 commit into from Oct 6, 2019

Conversation

elohmeier
Copy link
Contributor

Motivation for this change

update to latest stable version

Things done

switched to buildGoModule, targeted latest released stable version

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @avnik @vdemeester

@risicle
Copy link
Contributor

risicle commented Sep 8, 2019

On macos 10.13:

hash mismatch in fixed-output derivation '/nix/store/pv8dplcwn6yg7qzi1i0dx5qscrn12bmj-drone.io-1.3.1-go-modules':
  wanted: sha256:09mg1lrq93jpl98yp51mpqziarl5dgwm3ifi7f16lchvyy192k3f
  got:    sha256:128nnn8axnr30y3r46d11g8qznbsg82z2qw9qbxkq3bja6nz8fn2
cannot build derivation '/nix/store/hyp6420dgbcw3abh4n5f04jbdlwqn64a-drone.io-1.3.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/r43fl2f7nx2876p2zcg2pm37kklpjzlq-env.drv': 1 dependencies couldn't be built

@elohmeier
Copy link
Contributor Author

@risicle, thanks for your feedback. I've fixed the checksum.

@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
vdemeester
vdemeester approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rasendubi
Copy link
Member

@GrahamcOfBorg build drone

@matthiasbeyer
Copy link
Contributor

Can someone merge this?

avnik
avnik approved these changes Oct 6, 2019
View reviewed changes
Copy link
Contributor

@avnik avnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI said it's buildable (and I will check myself today later)

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 6, 2019

(retrying darwin build)
@GrahamcOfBorg build drone

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 6, 2019 •
edited

Darwin ✔️ so merging.

@elohmeier there's already newer versions upstream. drone-cli could also use a bump.
Feel free to submit another PR if you want to update those in nixpkgs. :)

EDIT: -> #70539 & #70540

@c0bw3b c0bw3b merged commit 50bd897 into NixOS:master Oct 6, 2019
@matthiasbeyer
Copy link
Contributor

Also feel free to submit a service definition and close #70519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasendubi rasendubi rasendubi left review comments

@vdemeester vdemeester vdemeester approved these changes

@avnik avnik avnik approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@elohmeier @risicle @rasendubi @matthiasbeyer @c0bw3b @vdemeester @avnik @lheckemann