Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 18b783b9bdb7
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5d1abc68e7b1
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Sep 7, 2019

  1. signal-desktop: Document the build "expiration" 

    This adds a comment why it's important to always backport any updates as
suggested in #68232. I've als included a few more details to document
the behaviour.

Sources:
- Default build lifetime [0]
- asar - Electron Archive [1]

[0]: https://github.com/signalapp/Signal-Desktop/blob/d3d2b0ec529ffd5ad74deb17831005a1acacc949/Gruntfile.js#L222
[1]: https://github.com/electron/asar
    @primeos
    primeos committed Sep 7, 2019
    Copy the full SHA
    5d1abc6 View commit details
Showing with 7 additions and 1 deletion.
  1. +7 −1 pkgs/applications/networking/instant-messengers/signal-desktop/default.nix
8 changes: 7 additions & 1 deletion pkgs/applications/networking/instant-messengers/signal-desktop/default.nix
View file
Original file line number Diff line number Diff line change
@@ -58,7 +58,13 @@ let

in stdenv.mkDerivation rec {
pname = "signal-desktop";
version = "1.27.2";
version = "1.27.2"; # Please backport all updates to the stable channel.
# All releases have a limited lifetime and "expire" 90 days after the release.
# When releases "expire" the application becomes unusable until an update is
# applied. The expiration date for the current release can be extracted with:
# $ grep -a "^{\"buildExpiration" "${signal-desktop}/libexec/resources/app.asar"
# (Alternatively we could try to patch the asar archive, but that requires a
# few additional steps and might not be the best idea.)

src = fetchurl {
url = "https://updates.signal.org/desktop/apt/pool/main/s/signal-desktop/signal-desktop_${version}_amd64.deb";