Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Zeronet, Init: pythonPackages: merkletools #68231

Merged
merged 2 commits into from Oct 2, 2019

Conversation

Chiiruno
Copy link
Contributor

@Chiiruno Chiiruno commented Sep 6, 2019

Motivation for this change

Update Zeronet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Chiiruno
Copy link
Contributor Author

Chiiruno commented Sep 8, 2019

Actually now that I think about it, is there any reason zeronet shouldn't be in python-modules instead of applications?

@fgaz
Copy link
Member

fgaz commented Sep 9, 2019

any reason zeronet shouldn't be in python-modules instead of applications?

AFAIK, we should be asking the opposite, since putting a python package in python-modules incurs a larger maintenance burden. Having a package in python-modules is only useful if it's a library which can be used by other packages

@Chiiruno
Copy link
Contributor Author

Chiiruno commented Sep 9, 2019

Okay, should be all fixed up now.
Thanks for informing me why that was unneeded. :P

@ofborg ofborg bot requested a review from fgaz September 9, 2019 08:04
Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks @Chiiruno!

@FRidh
Copy link
Member

FRidh commented Sep 9, 2019

@GrahamcOfBorg build zeronet

@Mic92 Mic92 merged commit d97e300 into NixOS:master Oct 2, 2019
@Chiiruno Chiiruno deleted the dev/zeronet branch October 2, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants