Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] signal-desktop: 1.26.2 -> 1.27.1 (backport) #68232

Merged
merged 1 commit into from Sep 7, 2019
Merged

[19.03] signal-desktop: 1.26.2 -> 1.27.1 (backport) #68232

merged 1 commit into from Sep 7, 2019

Conversation

primeos
Copy link
Member

@primeos primeos commented Sep 6, 2019

(cherry picked from commit 042b63d)
Reason: Avoid an expired (unusable) release in the stable release
(Signal-Desktop releases expire after a few months).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@primeos
signal-desktop: 1.27.1 -> 1.27.2
06ba45c 
(cherry picked from commit 042b63d)
Reason: Avoid an expired (unusable) release in the stable release
(Signal-Desktop releases expire after a few months).
@primeos
Copy link
Member Author

primeos commented Sep 6, 2019

@GrahamcOfBorg test signal-desktop

@primeos
Copy link
Member Author

primeos commented Sep 6, 2019

@ixmatus Regarding your last comment: Feel free to merge this PR if you want and if the test tests.signal-desktop on x86_64-linux passes ;)

@ofborg ofborg bot requested a review from ixmatus September 6, 2019 23:23
@worldofpeace
Copy link
Contributor

@primeos Perhaps you should add a comment in the expression like?

Please backport all updates. signal-desktop has no backwards compatibility and old releases expire.

@primeos
Copy link
Member Author

primeos commented Sep 7, 2019

@worldofpeace yeah, seems like a good idea to document it in the source-code as well. I'll try to come up with something later today and add some more details.

@primeos
Copy link
Member Author

primeos commented Sep 7, 2019

@GrahamcOfBorg test signal-desktop

@blitz
Copy link
Contributor

blitz commented Sep 7, 2019 •
edited

I've just tested this on my laptop in a Gnome3 session and it works for normal messaging. 👍

primeos added a commit that referenced this pull request Sep 7, 2019
@primeos
signal-desktop: Document the build "expiration"
5d1abc6 
This adds a comment why it's important to always backport any updates as
suggested in #68232. I've als included a few more details to document
the behaviour.

Sources:
- Default build lifetime [0]
- asar - Electron Archive [1]

[0]: https://github.com/signalapp/Signal-Desktop/blob/d3d2b0ec529ffd5ad74deb17831005a1acacc949/Gruntfile.js#L222
[1]: https://github.com/electron/asar
@primeos
Copy link
Member Author

primeos commented Sep 7, 2019

@blitz awesome, thanks! :)

@worldofpeace I've added the comment in 5d1abc6.

@primeos primeos merged commit 92650cb into NixOS:release-19.03 Sep 7, 2019
primeos added a commit to primeos/nixpkgs that referenced this pull request Sep 26, 2019
@primeos
signal-desktop: Document the build "expiration"
47729d0 
This adds a comment why it's important to always backport any updates as
suggested in NixOS#68232. I've als included a few more details to document
the behaviour.

Sources:
- Default build lifetime [0]
- asar - Electron Archive [1]

[0]: https://github.com/signalapp/Signal-Desktop/blob/d3d2b0ec529ffd5ad74deb17831005a1acacc949/Gruntfile.js#L222
[1]: https://github.com/electron/asar

(cherry picked from commit 5d1abc6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixmatus ixmatus Awaiting requested review from ixmatus

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@primeos @worldofpeace @blitz