Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.elpy: drop package #68217

Merged
merged 1 commit into from Sep 6, 2019
Merged

pythonPackages.elpy: drop package #68217

merged 1 commit into from Sep 6, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 6, 2019 •
edited

Motivation for this change

follow up to #60147

the package is no longer meaningful, and has been replaced with a dummy stub.

see jorgenschaefer/elpy#1583 for discussion

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @marsam

nix-review clears with no regressions

$ nix-env -f /home/jon/.cache/nix-review/pr-68217/nixpkgs -qaP --xml --out-path --show-trace --meta
Nothing changed
https://github.com/NixOS/nixpkgs/pull/68217
No packages were successfully build, skip nix-shell
$ git worktree prune

@FRidh FRidh merged commit 4bd7e96 into NixOS:master Sep 6, 2019
@jonringer jonringer deleted the remove-elpy branch September 6, 2019 22:40
@wildsebastian wildsebastian mentioned this pull request Sep 9, 2019
Merged
10 tasks
wildsebastian added a commit to wildsebastian/nixpkgs that referenced this pull request Sep 12, 2019
@wildsebastian
melpaPackages.elpy: bugfix
458e3c7 
After the elpy dummy package was removed (NixOS#68217) it was still referenced
in the melpa packages and broke emacs builds that included elpy.
@costrouc
Copy link
Member

Why was this package dropped? This was fixed with this PR #67518 by fetching from github

@jonringer
Copy link
Contributor Author

the pypi package now is essentially a no-op stub so that it didn't "break" other package installations. See the attached discussion. jorgenschaefer/elpy#1583

matthuszagh pushed a commit to matthuszagh/nixpkgs that referenced this pull request Sep 24, 2019
@wildsebastian @matthuszagh
melpaPackages.elpy: bugfix
ca97972 
After the elpy dummy package was removed (NixOS#68217) it was still referenced
in the melpa packages and broke emacs builds that included elpy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @costrouc @FRidh