Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webnfc] Impl "typedef DOMString NDEFRecordType" #18868

Merged
merged 1 commit into from Sep 9, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 5, 2019

This CL switches the IDL type definition from
"enum NDEFRecordType { "empty", "text", "url", "json", "opaque" };"
to
"typedef DOMString NDEFRecordType" according to web-nfc spec.

This is in preparation for supporting 'smart-poster' and external type
records in the future, which was added in
w3c/web-nfc#278.

BUG=520391

Change-Id: I45ec31afb3841cc5b12c954ffc2821da357fef04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781510
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#694635}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

This CL switches the IDL type definition from
"enum NDEFRecordType { "empty", "text", "url", "json", "opaque" };"
to
"typedef DOMString NDEFRecordType" according to web-nfc spec.

This is in preparation for supporting 'smart-poster' and external type
records in the future, which was added in
w3c/web-nfc#278.

BUG=520391

Change-Id: I45ec31afb3841cc5b12c954ffc2821da357fef04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781510
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#694635}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants