-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shuriken: init at 0.5.2 #68246
shuriken: init at 0.5.2 #68246
Conversation
shuriken fails on aarch64 |
{ stdenv, fetchFromGitHub, qmake, alsaLib, jack2, rubberband, aubio, libsndfile | ||
, liblo, libsamplerate }: | ||
|
||
stdenv.mkDerivation rec { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at #65399. You likely want to include mkDerivation
and use that directly, instead of from stdenv
. In that case you can entirely drop the reference to stdlib
and include lib
instead.
, liblo, libsamplerate }: | ||
|
||
stdenv.mkDerivation rec { | ||
name = "shuriken-${version}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using pname = "shrukin";
is now the preferred way to set the application name because name = "${pname}-${version}";
is implied.
|
||
meta = with stdenv.lib; { | ||
description = "Shuriken beat slicer"; | ||
homepage = https://github.com/rock-hopper/shuriken; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please quote.
popd | ||
''; | ||
|
||
meta = with stdenv.lib; { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include a maintainer
if possible.
Thank you for your contributions.
|
I marked this as stale due to inactivity. → More info |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @