Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prusa-slicer: 2.0.0 -> 2.1.0 #68248

Merged
merged 3 commits into from Oct 14, 2019
Merged

prusa-slicer: 2.0.0 -> 2.1.0 #68248

merged 3 commits into from Oct 14, 2019

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Sep 7, 2019 •
edited

Motivation for this change

Preparing for update to 2.1.0.

There is a new dependency needed, cereal. This PR adds a package for that as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Moredread
Copy link
Contributor Author

cc @mweinelt @ArdaXi @baracoder @thorstenweber83 as you were interested in the previous PR. :)

@mweinelt
Copy link
Member

mweinelt commented Sep 7, 2019 •
edited

Unrelated, but FYI: There has also been a new firmware release https://github.com/prusa3d/Prusa-Firmware/releases/tag/v3.8.0.

Build is running, will report back asap.

Update: Runs smoothly, couldn't identify any issues while clicking around for a few minutes. Will be until tonight until I can actually test a print though.

Update: Print runs, everything seems to be working.

@mweinelt
Copy link
Member

2.1.0-rc2 is out and is supposed to fix prusa3d/PrusaSlicer#2619 (comment).

@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
@Moredread
Copy link
Contributor Author

@mweinelt I've updated the PR for rc2.

@mweinelt
Copy link
Member

Yup, still looking good.

@Moredread
Copy link
Contributor Author

I'm not sure how to handle cereal. I'm currently not comfortable to maintain it myself and it is only used for prusa-slicer in NixOS.

Would inlining it in the prusa-slicer derivation be better than having a separate package without a maintainer?

@Moredread Moredread changed the title WIP: prusa-slicer: 2.0.0 -> 2.1.0-rc WIP: prusa-slicer: 2.0.0 -> 2.1.0 Sep 19, 2019
@Moredread
cereal: init at 1.2.2
f2fd138
@Moredread
prusa-slicer: 2.0.0 -> 2.1.0
5c95ab0
@Moredread
prusa-slicer: add Eigen as dependency
dda8e47 
Previously compilation failed when using our version of Eigen. Now it
works again.
@Moredread Moredread changed the title WIP: prusa-slicer: 2.0.0 -> 2.1.0 prusa-slicer: 2.0.0 -> 2.1.0 Sep 23, 2019
@Mic92
Copy link
Member

Mic92 commented Sep 23, 2019

@GrahamcOfBorg build prusa-slicer

@flokli
Copy link
Contributor

flokli commented Oct 14, 2019

cereal itself seems quite useful, and it'd be a pity if it'd be inacessible just because there's not maintainer for it.

The derivation also looks quite trivial, let's keep it like it is currently.

@flokli flokli merged commit 79676a2 into NixOS:master Oct 14, 2019
@Moredread Moredread deleted the slicer branch October 14, 2019 19:08
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 15, 2019
@flokli @dtzWill
Merge pull request NixOS#68248 from Moredread/slicer
1ae01be 
prusa-slicer: 2.0.0 -> 2.1.0
(cherry picked from commit 79676a2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Moredread @mweinelt @Mic92 @flokli @lheckemann