Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.pkgs.python-jenkins: 1.4.0 -> 1.5.0 #68161

Closed
wants to merge 1 commit into from
Closed

python3.pkgs.python-jenkins: 1.4.0 -> 1.5.0 #68161

wants to merge 1 commit into from

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Sep 5, 2019

Motivation for this change
35f660a (HEAD -> master, tag: 1.5.0, origin/master, origin/HEAD) Merge "When updating jobs the response body may be empty"
ac7fc35 Merge "Make get_job_info fetch_all_builds work with jobs in folders"
0ab91c7 Remove pin on mock module
748aa20 Update jobs
190fbbb Make get_job_info fetch_all_builds work with jobs in folders
a5615d0 OpenDev Migration Patch
a2c6f6a When updating jobs the response body may be empty
5c28725 Merge "add python 3.6 unit test job"
4a7c4ff Add Python 3.6 classifier to setup.cfg
9f77e68 add python 3.6 unit test job

Currently, 2 of the 590 tests fail on Python 3.x. I opened https://bugs.launchpad.net/python-jenkins/+bug/1842963 about that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Ma27

@flokli flokli requested a review from Ma27 September 5, 2019 18:42
@tomfitzhenry
Copy link
Contributor

tomfitzhenry commented Nov 17, 2019 •
edited

@flokli, should this PR still be in draft?

@flokli
Copy link
Contributor Author

flokli commented Nov 17, 2019

@tomfitzhenry The unit tests still fail, there hasn't been any reaction in the upstream bug report, and I won't be using this python module either, as I'm in progress of moving away from Jenkins.

I'll close this PR, if either you of @Ma27 want to pick up from here, feel free to open a new PR with that bump :-)

@flokli flokli closed this Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @tomfitzhenry