mudlet: 3.0.0-delta -> 4.0.3 (fixes broken package) #68158

pstn · 2019-09-05T17:56:17Z

Motivation for this change

mudlet has been broken for a while now. I managed to fix and upgrade it to the most recent version.

I added myself as a maintainer since nobody else seems to have interest in that package any more.

Thanks to @abbradar for the help and the patch to upstream.

Things done

Notify maintainers

cc @Wyvie

pstn · 2019-09-05T19:54:03Z

The current maintainer has been inactive for quite some time, so please consider reviewing this even if you are not them.

teto · 2019-09-06T05:03:11Z

pkgs/games/mudlet/default.nix

+
+    makeQtWrapper $out/mudlet $out/bin/mudlet \
+      --set LUA_CPATH "${luaFileSystemPath};${luaZipPath};${lrexlibPath};${luasqlitePath};${luayajlPath};${luaUtf8Path}" \
+      --prefix LUA_PATH : "$NIX_LUA_PATH" \


have you tried using an environment instead? luaEnv = lua.withPackages(p: [luaFileSystemPath ...]). Will make the path simpler and indenpendant of the lua version, like one could override with lua52 and still have the paths valid instead of luaUtf8Path = "${luautf8}/lib/lua/5.1/?.so";

I didn't because I didn't know about that method. You are right. It's way cleaner.
I couldn't get rid of all dependencies on the lua version, but I moved that version in a variable at the top for easier maintenance and discovery.

Scratch that. Got it working by overwriting the lua version in all-packages.nix.

pstn · 2019-09-06T09:35:45Z

Removed a few dependencies that became unneeded but I forgot to clean up.

abbradar · 2019-09-06T11:17:51Z

pkgs/games/mudlet/default.nix

+  WITH_FONTS = false;
+  WITH_UPDATER = "NO";
+
+  preConfigure = ''


Perhaps this is not needed now that we use withPackages?

preConfigure removed.

abbradar · 2019-09-06T11:18:23Z

pkgs/games/mudlet/default.nix

  ];

-  preConfigure = "cd src";
+  WITH_FONTS = false;


Use "NO" here too for consistency and because I'm not sure false would work but "NO" is used by AUR package.

abbradar

@teto, can you check Lua stuff once more just in case before we merge?

teto · 2019-09-07T06:46:06Z

pkgs/games/mudlet/default.nix

-  nativeBuildInputs = [ makeWrapper qmake ];
+  patches = [
+    ( fetchpatch {
+      url = "https://github.com/abbradar/Mudlet/commit/4f9450e9f66ac72f502e52951ff04b8ac8d123b3.patch";


may be best for the patch to live in nixpkgs ?

They already merged it upstream actually: Mudlet/Mudlet@6306f99

I had it in nixpkgs but @abbradar wanted me to pull it from their repo.

I think i like it better this way because you could access more information about the patch when you know how to handle the link.

the issue is that url points towards @abbradar url. so if he deletes his fork or the branch, the package will stop compiling. If the patch were in nixpkgs then we are in control. Referencing the upstreaming patch should be fine as if their commit disappear, it means we will have problems anyway.

Ah, got it. fetching the patch from mudlet/mudlet now.

teto

there are too many changes in the lua generated packages list. I wonder if some of them are linked with the luarocks update.
Many seem to have changed to luafr.org, which is a mirror of the luarocks server. Are you based in france by any chance @pstn ? This is something I need to fix in luarocks2nix Meanwhile you could just restrict the changes in in generated-packages.nix to only the changes you need (with git add -p).

Dependency for mudlet >= 4.0

pstn · 2019-09-07T10:32:42Z

No, I'm in Germany.

I did discard all the unneeded changes in both commits. Thanks for your help.

teto · 2019-09-07T11:06:21Z

No, it's me thanking you ! I wanted this package to use lua environments for at least a year but fixing it proved too difficult. Not only did you do it but you also found some issue in how the lua packages are generated. I have a fix I will submit soon.
The last thing I would like to see before merging is to fetch the patch from the mudlet's repo. Thanks for keeping up with us.

Fixed broken package.

teto · 2019-09-07T11:47:58Z

@GrahamcOfBorg build luaPackages.mudlet

teto · 2019-09-07T14:05:41Z

not sure why it's stuck, I ran a nix-review on x86-64 and it worked. Merging. Thanks to all those involved.

ofborg bot added the 6.topic: lua label Sep 5, 2019

pstn force-pushed the mudlet branch from 143143b to 55cbe5e Compare September 5, 2019 18:06

pstn changed the title ~~Mudlet~~ mudlet: 3.0.0-delta -> 4.0.3 (fixes broken package) Sep 5, 2019

ofborg bot added 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Sep 5, 2019

teto reviewed Sep 6, 2019

View reviewed changes

pstn force-pushed the mudlet branch 2 times, most recently from 7e75918 to 807f240 Compare September 6, 2019 09:34

pstn force-pushed the mudlet branch 2 times, most recently from 74fec34 to d643e2d Compare September 6, 2019 10:52

abbradar mentioned this pull request Sep 6, 2019

Upstream URLs are seemingly randomized nix-community/luarocks-nix#5

Closed

abbradar reviewed Sep 6, 2019

View reviewed changes

pstn force-pushed the mudlet branch 2 times, most recently from 1774d6d to 20702b1 Compare September 6, 2019 11:51

abbradar approved these changes Sep 6, 2019

View reviewed changes

teto reviewed Sep 7, 2019

View reviewed changes

teto requested changes Sep 7, 2019

View reviewed changes

teto mentioned this pull request Sep 7, 2019

Meta issue about lua ecosystem progress #56398

Open

30 tasks

Philipp added 2 commits September 7, 2019 12:23

lua*Packages.luautf8: init at 0.1.1-1

a26d9f2

Dependency for mudlet >= 4.0

lua*Packages.lua-yajl: init at 2.0-1

d511b9b

Dependency for mudlet >= 4.0

pstn force-pushed the mudlet branch from 20702b1 to 8432da6 Compare September 7, 2019 10:28

ofborg bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 11-100 labels Sep 7, 2019

mudlet: 3.0.0-delta -> 4.0.3

776d735

Fixed broken package.

pstn force-pushed the mudlet branch from 8432da6 to 776d735 Compare September 7, 2019 11:23

teto mentioned this pull request Sep 7, 2019

Luarocks nix bump #68258

Merged

10 tasks

teto merged commit 3b5b9a7 into NixOS:master Sep 7, 2019

pstn deleted the mudlet branch September 12, 2019 14:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mudlet: 3.0.0-delta -> 4.0.3 (fixes broken package) #68158

mudlet: 3.0.0-delta -> 4.0.3 (fixes broken package) #68158

pstn commented Sep 5, 2019 •

edited

Loading

pstn commented Sep 5, 2019

teto Sep 6, 2019

pstn Sep 6, 2019

pstn Sep 6, 2019

pstn commented Sep 6, 2019

abbradar Sep 6, 2019

pstn Sep 6, 2019

abbradar Sep 6, 2019

pstn Sep 6, 2019

abbradar left a comment

teto Sep 7, 2019

abbradar Sep 7, 2019

pstn Sep 7, 2019

teto Sep 7, 2019

pstn Sep 7, 2019

teto left a comment

pstn commented Sep 7, 2019

teto commented Sep 7, 2019

teto commented Sep 7, 2019

teto commented Sep 7, 2019

mudlet: 3.0.0-delta -> 4.0.3 (fixes broken package) #68158

mudlet: 3.0.0-delta -> 4.0.3 (fixes broken package) #68158

Conversation

pstn commented Sep 5, 2019 • edited Loading

Motivation for this change

Things done

Notify maintainers

pstn commented Sep 5, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pstn commented Sep 6, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abbradar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

teto left a comment

Choose a reason for hiding this comment

pstn commented Sep 7, 2019

teto commented Sep 7, 2019

teto commented Sep 7, 2019

teto commented Sep 7, 2019

pstn commented Sep 5, 2019 •

edited

Loading