Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghq: Migrate to buildGoModule, ensure go 1.13 compatibility #68160

Merged
merged 2 commits into from Sep 10, 2019

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Preparation for #68135 (Go 1.13 compatiblity)
Refs #68135 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @sigma

@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build ghq

@rvolosatovs
Copy link
Member Author

Blocks #68135

@rvolosatovs
Copy link
Member Author

@Mic92 - addressed your comment from #68135 (review)
can you merge this?

@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
@Mic92 Mic92 merged commit df02b1d into NixOS:master Sep 10, 2019
@rvolosatovs rvolosatovs deleted the fix/ghq branch September 10, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants