Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs: 0.4.21 -> 0.4.22, use Go 1.12 #68159

Merged
merged 1 commit into from Sep 9, 2019
Merged

ipfs: 0.4.21 -> 0.4.22, use Go 1.12 #68159

merged 1 commit into from Sep 9, 2019

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Upstream update, ensure Go 1.12 is used in preparation for #68135

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fpletz

@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build ipfs

@ofborg ofborg bot requested review from fpletz and kalbasit September 5, 2019 18:38
@risicle
Copy link
Contributor

risicle commented Sep 6, 2019

nix-review builds macos 10.13 & non-nixos linux x86_64, binary seems to work.

@veprbl
Copy link
Member

veprbl commented Sep 8, 2019

Could you please mention why can't ipfs use Go 1.13? The official README doesn't mention this as a problem: https://github.com/ipfs/go-ipfs/blob/master/README.md#install-go

@rvolosatovs
Copy link
Member Author

rvolosatovs commented Sep 9, 2019 •
edited

@veprbl https://github.com/NixOS/nixpkgs/pull/68159/files#diff-036410e9211b4336186fc613f7200b12R4005-R4007

FTR, current master of ipfs successfully builds on 1.13.
I initially wanted to just apply (their) patch, but in the fix they also made a general dependency update, and IMO that's getting out of scope for our purpose.
I can also just create my own patch to fix the version such that we can use go 1.13 - please tell me which one you prefer.

@rvolosatovs
Copy link
Member Author

Blocks #68135

@veprbl
Copy link
Member

veprbl commented Sep 9, 2019

@rvolosatovs Having the issue documented like you did should be sufficient. Thank you.

@GrahamcOfBorg build ipfs

veprbl
veprbl approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs on NixOS and darwin

@veprbl veprbl merged commit 2c70240 into NixOS:master Sep 9, 2019
@rvolosatovs rvolosatovs deleted the update/ipfs branch September 9, 2019 18:21
@flokli flokli mentioned this pull request Dec 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rvolosatovs @risicle @veprbl