dehydrated: move to pname syntax, handle docs/manpage. #68266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| installPhase = '' | ||
| mkdir -p "$out/share/man/man1" | ||
| gzip < docs/man/dehydrated.1 > "$out/share/man/man1/dehydrated.1.gz" |
There was a problem hiding this comment.
Can you use installManPage like
Suggested change
| gzip < docs/man/dehydrated.1 > "$out/share/man/man1/dehydrated.1.gz" | |
| installManPage docs/man/dehydrated.1 |
comes from installShellFiles
There was a problem hiding this comment.
not sure if the mkdir will be unseeded with this, but it's worth checking.
There was a problem hiding this comment.
mkdir doesn't seem to be needed with installManPage. Thanks for the hint!
pstn
force-pushed
the
dehydrated-modernisation
branch
from
a768e9a
to
274b865
Compare
worldofpeace
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Does not change the actual functionality of the package, but moves the docs to the output and also puts the man page that has been added by upstream since the original creation of this package.
Also added two minor tweaks: moved
makeWrapperintonativeBuildInputswhere it belongs and moved the package to the newpnamesyntax.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc