Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unsupported go version 1.11 #68195

Merged
merged 3 commits into from Sep 11, 2019
Merged

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Sep 6, 2019

Motivation for this change

Go 1.11 is unsupported by upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

Can maintainers of packages marked as broken fix your respective packages in a separate PR and reference this PR so I can drop those commits setting broken = true?
cc @fpletz @nlewo

Also CCing the contributors who latest updated those packages:
@volth @kamilchm

I'd like a solution to all filebeats version using pinned old compiler versions, they are currently the only thing left in the tree referencing buildGo111Package.
Beats have been fixed to build with Go 1.12.
CC beats maintainers @fadenb @basvandijk

CCing Go maintainers
@cstrahan @orivej @velovix @Mic92

@adisbladis adisbladis changed the title Drop unsupported go version 1.11 WIP: Drop unsupported go version 1.11 Sep 6, 2019
@adisbladis adisbladis mentioned this pull request Sep 6, 2019
10 tasks
@adisbladis adisbladis force-pushed the drop-go-1_11 branch 2 times, most recently from 510c14a to a72ae26 Compare September 7, 2019 14:40
@adisbladis adisbladis changed the title WIP: Drop unsupported go version 1.11 Drop unsupported go version 1.11 Sep 7, 2019
@nlewo
Copy link
Member

nlewo commented Sep 9, 2019

@adisbladis Regarding the broken build of Skydive, I've tried to update it, but it fails for non trivial reasons and I'm no longer using it. So, I would prefer to remove myself from the maintainer list.
Since I'm the only maintainer, should I also remove the Skydive package?

@Mic92
Copy link
Member

Mic92 commented Sep 9, 2019

@nlewo yes. You can open a PR for that and if nobody jumps in, we remove it from nixpkgs.

@lheckemann
Copy link
Member

From when is it unsupported? Should this be backported to 19.09?

@adisbladis
Copy link
Member Author

@lheckemann Go upstream only supports the 2 most recent releases. This should be in 19.09.

@lheckemann lheckemann added this to the 19.09 milestone Sep 10, 2019
@adisbladis adisbladis merged commit 7782fcf into NixOS:master Sep 11, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 27, 2020
Drop unsupported go version 1.11

(cherry picked from commit 7782fcf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants