New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop unsupported go version 1.11 #68195
Conversation
510c14a
to
a72ae26
Compare
@adisbladis Regarding the broken build of Skydive, I've tried to update it, but it fails for non trivial reasons and I'm no longer using it. So, I would prefer to remove myself from the maintainer list. |
@nlewo yes. You can open a PR for that and if nobody jumps in, we remove it from nixpkgs. |
From when is it unsupported? Should this be backported to 19.09? |
@lheckemann Go upstream only supports the 2 most recent releases. This should be in 19.09. |
Fix build with latest Go
It's unsupported by upstream.
a72ae26
to
3e501fe
Compare
Drop unsupported go version 1.11 (cherry picked from commit 7782fcf)
Motivation for this change
Go 1.11 is unsupported by upstream.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
Can maintainers of packages marked as broken fix your respective packages in a separate PR and reference this PR so I can drop those commits setting broken = true?
cc @fpletz @nlewo
Also CCing the contributors who latest updated those packages:
@volth @kamilchm
I'd like a solution to all filebeats version using pinned old compiler versions, they are currently the only thing left in the tree referencing buildGo111Package.Beats have been fixed to build with Go 1.12.
CC beats maintainers @fadenb @basvandijk
CCing Go maintainers
@cstrahan @orivej @velovix @Mic92