Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unsupported go version 1.10 #68194

Merged
merged 13 commits into from Sep 6, 2019
Merged

Drop unsupported go version 1.10 #68194

merged 13 commits into from Sep 6, 2019

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Sep 6, 2019 •
edited

Motivation for this change

Go 1.10 is unsupported by upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@adisbladis
Copy link
Member Author

@GrahamcOfBorg build prometheus-snmp-exporter diskrsync prometheus_1 perkeep dnscrypt-proxy2 tmsu notary goa ipget fscrypt

@adisbladis
Copy link
Member Author

CC maintainers: @lethalman @kalbasit @waynr @cstrahan @oida @Ma27 @pSub @jluttine @vdemeester @WilliButz @rushmorem @benley @primeos @fpletz @globin

@adisbladis adisbladis mentioned this pull request Sep 6, 2019
Merged
10 tasks
vdemeester
vdemeester approved these changes Sep 6, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me 👍

@WilliButz
Copy link
Member

@GrahamcOfBorg test prometheus-exporters.snmp

LGTM 👍
As a sidenote, I personally think we need to drop prometheus1 asap but that's out of scope for this PR and should be done separately :)

@FRidh FRidh merged commit 9b92496 into NixOS:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@WilliButz WilliButz WilliButz approved these changes

Assignees
No one assigned
Labels
6.topic: golang 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adisbladis @WilliButz @vdemeester @FRidh