Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zeroc-ice: fix on Darwin #68235

Closed
wants to merge 1 commit into from
Closed

zeroc-ice: fix on Darwin #68235

wants to merge 1 commit into from
+11 −4

Conversation

abbradar
Copy link
Member

@abbradar abbradar commented Sep 7, 2019

Motivation for this change

Fix Darwin build (forgot to test it in the original PR).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@abbradar abbradar requested a review from FRidh as a code owner September 7, 2019 00:08
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 7, 2019
@abbradar
Copy link
Member Author

abbradar commented Sep 7, 2019

@GrahamcOfBorg build zeroc-ice python3.pkgs.zeroc-ice

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg eval

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 7, 2019
@abbradar
Copy link
Member Author

abbradar commented Sep 7, 2019

@GrahamcOfBorg build zeroc-ice python3.pkgs.zeroc-ice

@abbradar
zeroc-ice: fix on Darwin

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8c2f94a
@abbradar
Copy link
Member Author

abbradar commented Sep 7, 2019

@GrahamcOfBorg build zeroc-ice python3.pkgs.zeroc-ice

@abbradar
Copy link
Member Author

abbradar commented Sep 7, 2019

I don't have any ideas now ;_; See https://logs.nix.ci/?key=nixos/nixpkgs.68235&attempt_id=88c25d05-7d56-41d0-a677-612bf33bd3f3 , both errors seem strange to me.

Perhaps someone with actual Darwin machine could chip in?

@risicle
Copy link
Contributor

risicle commented Sep 7, 2019

nix-review fails with 4 build failures for me, macos 10.13:

https://gist.github.com/risicle/9c941976b01f9b4e841088e577625bc4
https://gist.github.com/risicle/aedc9fb1d41274a623aad810dd36fb7e
https://gist.github.com/risicle/c266eb241003e2acdfff62a8ee081064
https://gist.github.com/risicle/25ff9dca6d02b04840b5db90ba8e3415

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@ryantm ryantm added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 3, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@siraben
Copy link
Member

siraben commented Mar 7, 2021

Please resolve the merge conflict.

@stale
Copy link

stale bot commented Sep 6, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 6, 2021
@abbradar
Copy link
Member Author

This is definitely too stale now and I don't remember the specifics, let's close.

@abbradar abbradar closed this Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@abbradar @worldofpeace @risicle @siraben @ryantm