Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP nixos/sks: init script: build from .{gpg=>pgp} files #68238

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

WIP nixos/sks: init script: build from .{gpg=>pgp} files #68238

wants to merge 2 commits into from
+2 −1

Conversation

wldhx
Copy link
Member

@wldhx wldhx commented Sep 7, 2019

Motivation for this change

All current dumps seem to do .pgp, e.g. https://keys.niif.hu/keydump/, http://stueve.us/keydump/.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @primeos @calbrecht @jcumming

Sorry, something went wrong.

@wldhx
nixos/sks: init script: build from .{gpg=>pgp} files

Verified

This commit was signed with the committer’s verified signature.
dadada Tim Schubert
GPG key ID: EEB8D1CE62C4DFEA
Verified
Learn about vigilant mode
0c74beb 
All current dumps seem to do .pgp, e.g. https://keys.niif.hu/keydump/, http://stueve.us/keydump/.
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 7, 2019
@wldhx wldhx changed the title nixos/sks: init script: build from .{gpg=>pgp} files WIP nixos/sks: init script: build from .{gpg=>pgp} files Sep 7, 2019
@wldhx
Copy link
Member Author

wldhx commented Sep 7, 2019

Found another small issue or two it would make sense to tackle in one PR, marking WIP for now.

@wldhx
nixos/sks: TimeoutStartSec = 1h

Verified

This commit was signed with the committer’s verified signature.
dadada Tim Schubert
GPG key ID: EEB8D1CE62C4DFEA
Verified
Learn about vigilant mode
561071f 
Initial keydump import timeouts otherwise.
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg eval

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 7, 2019
@primeos primeos self-assigned this Sep 7, 2019
primeos
primeos requested changes Sep 7, 2019
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes :)

Unfortunately this module most likely only works well for small standalone keyservers atm. #24516 might also be interesting if you're trying to setup a synchronizing keyserver.

nixos/modules/services/security/sks.nix
@@ -116,7 +116,7 @@ in {
${lib.optionalString (cfg.webroot != null)
"ln -sfT \"${cfg.webroot}\" web"}
mkdir -p dump
${sksPkg}/bin/sks build dump/*.gpg -n 10 -cache 100 || true #*/
${sksPkg}/bin/sks build dump/*.pgp -n 10 -cache 100 || true #*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks :) Should've been .pgp in the first place.

Can you please change the suffix in the documentation of the enable option as well?

nixos/modules/services/security/sks.nix
@@ -138,6 +138,7 @@ in {
User = "sks";
Group = "sks";
Restart = "always";
TimeoutStartSec = "1h";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you import a complete dump from the synchronizing keyservers? And if so, how long did it take?

Maybe we should set it to an even higher value or infinity to cover slower systems as well. It might also help to add a comment like # Increase the timeout for the initial DB build at the end of the line to document this for the future.

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@calbrecht
Copy link
Member

Honestly i don't run this, but at our company we do. So /cc @globin

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@ryantm ryantm marked this pull request as draft October 23, 2020 03:05
@stale
Copy link

stale bot commented Apr 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 26, 2021
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos

Requested changes must be addressed to merge this pull request.

Assignees

@primeos primeos

Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wldhx @worldofpeace @calbrecht @primeos @wegank