Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/installer: use libinput over synaptics #68237

Closed
wants to merge 1 commit into from
Closed

nixos/installer: use libinput over synaptics #68237

wants to merge 1 commit into from
+1 −1

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 7, 2019 •
edited
Loading

Motivation for this change

noticed ofborg not being able to eval because of an assertion, this is to help remedy it

example failure

I believe this bug was introduced in #68233

cc @worldofpeace

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 7, 2019
@jonringer
Copy link
Contributor Author

Now that I think about it, we could probably do away with explicitly setting this altogether in the installer expression. Not sure which would be more correct.

@jonringer
Copy link
Contributor Author

i would do ofborg test installer, but it seems to be incredibly resource intensive with building a new kernel.

@jtojnar
Copy link
Member

jtojnar commented Sep 7, 2019

See also #67305

@jonringer
Copy link
Contributor Author

I did, the issue I'm trying to fix is that ofborg is erroring on all other PRs right now because that one image has both synaptic and libinput enabled.

@worldofpeace
Copy link
Contributor

worldofpeace commented Sep 7, 2019 •
edited
Loading

noticed ofborg not being able to eval because of an assertion, this is to help remedy it

Ahh, that was a pretty sneaky issue.
I think I'll push 6b0cc75 since we've pretty much agreed on that, and I will test the image briefly.

@worldofpeace
Copy link
Contributor

b3a06f1

@jonringer jonringer deleted the fix-nixos-eval branch September 7, 2019 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @jtojnar @worldofpeace