Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] signal-desktop: 1.26.2 -> 1.27.1 (backport) #68177

Merged
merged 1 commit into from Sep 6, 2019
Merged

[19.03] signal-desktop: 1.26.2 -> 1.27.1 (backport) #68177

merged 1 commit into from Sep 6, 2019

Conversation

primeos
Copy link
Member

@primeos primeos commented Sep 5, 2019

at-spi2-core is required for the new dependency on libatspi.so.0.

(cherry picked from commit 539d66a)
Reason: Avoid an expired (unusable) release in the stable release (Signal-Desktop releases expire after a few months).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@primeos
signal-desktop: 1.26.2 -> 1.27.1
bfbd6ce 
at-spi2-core is required for the new dependency on libatspi.so.0.

(cherry picked from commit 539d66a)
@primeos primeos self-assigned this Sep 5, 2019
@primeos
Copy link
Member Author

primeos commented Sep 5, 2019

@GrahamcOfBorg test signal-desktop

@ofborg ofborg bot requested a review from ixmatus September 5, 2019 22:28
@primeos primeos merged commit ff05bc4 into NixOS:release-19.03 Sep 6, 2019
@ixmatus
Copy link
Contributor

ixmatus commented Sep 6, 2019

Oh oops, I forgot I now have privileges to merge 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixmatus ixmatus ixmatus approved these changes

Assignees

@primeos primeos

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@primeos @ixmatus