Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reftest for width of first-letter #18882

Merged

Conversation

astearns
Copy link
Contributor

@astearns astearns commented Sep 5, 2019

Copy link
Contributor

@frivoal frivoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand what causes Mozilla to fail this test currently, but I agree that that test is correct (there should be not red if everything goes normally), and that Mozilla does get tripped up by it, making it a useful test.

So, Approved, and you can merge.

Out of context, this test may be a bit surprising though, so adding a comment pointing to the bugzilla entry that justified it may help people looking at it in the future.

@frivoal frivoal merged commit 5ac316e into web-platform-tests:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants