Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protonmail-bridge: 1.1.6-1 -> 1.2.2-1 #68274

Merged
merged 2 commits into from Sep 17, 2019
Merged

protonmail-bridge: 1.1.6-1 -> 1.2.2-1 #68274

merged 2 commits into from Sep 17, 2019

Conversation

lightdiscord
Copy link
Member

Motivation for this change

Update protonmail-bridge

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GRBurst
Copy link
Contributor

GRBurst commented Sep 8, 2019

@lightdiscord if you have some more time could you use the provided desktop file?

worldofpeace mentioned it after the last upgrade in #65315 (comment)

After merging this I noticed that the archive includes a desktop file that's more complete than the one we generate.

[Desktop Entry]
Name=ProtonMail Bridge
GenericName=ProtonMail Bridge for Linux
Comment=The Bridge is an application that runs on your computer in the background and seamlessly encrypts and decrypts your mail as it enters and leaves your computer.
Exec=protonmail-bridge
Icon=/usr/share/icons/protonmail/ProtonMail_Bridge.svg
Type=Application
Version=1.0
Terminal=false
Categories=Utility;Security;Network;Email

Though those paths would need to be patched with substitute.

@lightdiscord
Copy link
Member Author

Done!

@GRBurst
Copy link
Contributor

GRBurst commented Sep 10, 2019

Works like a charm 👍

@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
worldofpeace
worldofpeace approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Verified the desktop item is patched correctly.

@worldofpeace worldofpeace merged commit 41ac894 into NixOS:master Sep 17, 2019
@lightdiscord lightdiscord deleted the packages/protonmail-bridge-update-1-2-2-1 branch September 17, 2019 18:33
@karolchmist karolchmist mentioned this pull request Sep 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lightdiscord @GRBurst @worldofpeace @lheckemann