Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Win32] Use sRGB for graphics output. #7724

Closed
wants to merge 1 commit into from

Conversation

michicc
Copy link
Member

@michicc michicc commented Sep 7, 2019

This is a draft PR as, while working as far as I can tell, it causes a heavy performance hit at least on my machine.

Further data points on this gladly taken.

…to colour space of the display happends to be.
@michicc michicc added the OS: Windows This issue is related to a MS Windows problem label Sep 7, 2019
@andythenorth andythenorth changed the title [Win32] Use sRGB for grahpics output. [Win32] Use sRGB for graphics output. Dec 27, 2019
@TrueBrain TrueBrain added candidate: needs considering This Pull Request needs more opinions size: large This Pull Request is large in size; review will take a while labels Dec 14, 2020
@TrueBrain
Copy link
Member

Nobody gave you any datapoints? :( Evil .. if you like, you can rebase this, and we can create a binary to attach here, so it is easier for others to try out the Windows build? Would that help?

@michicc
Copy link
Member Author

michicc commented Dec 21, 2020

I can rebase. I'm not really sure it's worth it, though. More or less every 3D game out there is not running colour-corrected, and apparently nobody cares.

@michicc michicc closed this Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
candidate: needs considering This Pull Request needs more opinions OS: Windows This issue is related to a MS Windows problem size: large This Pull Request is large in size; review will take a while
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants