Staging next that includes gcc8 #68244
Conversation
Added the `-Wno-error=array-bounds` flag. Fixes #40213.
systemd: suppress certain warnings to compile under gcc8
This test is broken because gcc8.x86_64-darwin is broken. Please add the test back in once we have fixed it! Job: https://hydra.nixos.org/job/nixpkgs/trunk/gcc8.x86_64-darwin Issue: #40038
gcc,gcc8: {revert gcc to gcc7, mark gcc8 as broken} on Darwin
gcc8: merge branch master
llvm6: default to gcc7 instead of gcc8
* elfutils: add patch that fixes compilation under gcc8 * elfutils: follow advice from @jtojnar
Broke xen and virtualbox. This reverts commit d2f2132.
|
Maybe gcc8 got force-pushed removing it |
|
No, see comments on #63132 |
|
@vcunat will you merge gcc-8 or shall I? |
|
I can't make it today. |
Earlier the gcc8 branch was merged instead of the gcc-8 branch (note the dash)...
|
OK. Now gcc-8 is in (5f4734b). |
|
Would you consider picking #68096 for this iteration of staging next as well? It seems to be fairly low impact on the overall systems besides the extra rebuilds. Having this through staging would help us having it accepted for 19.09. |
|
Oh, I wondered if this release should only get one large feature merged on the last day (which is past the planned fork-off date), but apparently we end up the same on every release :-) |
The build was fixed in two ways, by both this patch and a substitution. Let's keep the substitition instead of the patch as the patches may disappear. This reverts commit ccc8c73.
|
proposed eval fix #68324 |
This was present in the gcc-8 branch but got removed in the merge.
|
It seems this merge broke building my builds with musl (due to a new |
See * NixOS#68244 (comment) * nh2/static-haskell-nix#56 This commit takes care to not change the derivation for non-musl builds.
PR to fix it: #71480 |
GCC 8 introduced new warnings that were picked up by -Werror; this commit makes them non-errors until fixed upstream. See * NixOS#68244 (comment) * nh2/static-haskell-nix#56 This commit takes care to not change the derivation for non-musl builds.
GCC 8 introduced new warnings that were picked up by -Werror; this commit makes them non-errors until fixed upstream. See * NixOS#68244 (comment) * nh2/static-haskell-nix#56 This commit takes care to not change the derivation for non-musl builds. (cherry picked from commit 08ec575)
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @