Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-adfs: 1.12.3 -> 1.17.0 #68183

Merged
merged 1 commit into from Sep 22, 2019
Merged

aws-adfs: 1.12.3 -> 1.17.0 #68183

merged 1 commit into from Sep 22, 2019

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Sep 6, 2019

Motivation for this change

Routine upgrade to latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple bhipple requested a review from FRidh as a code owner September 6, 2019 04:01
@bhipple
Copy link
Contributor Author

bhipple commented Sep 6, 2019

@GrahamcOfBorg build python2Packages.aws-adfs python3Packages.aws-adfs

jonringer
jonringer approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM (one suggestion)
executable seems to work
leaf package

[4 built, 4 copied (5.0 MiB), 1.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68183
2 package were build:
python27Packages.aws-adfs python37Packages.aws-adfs

pkgs/development/python-modules/aws-adfs/default.nix Show resolved Hide resolved
@bhipple
aws-adfs: 1.12.3 -> 1.17.0
7b4132f 
This commit also adds it as an application in all-packages.nix, since it's
typically used as just a stand-alone cmdline tool.
@bhipple
Copy link
Contributor Author

bhipple commented Sep 10, 2019

@GrahamcOfBorg build aws-adfs python2Packages.aws-adfs python3Packages.aws-adfs

@bhipple
Copy link
Contributor Author

bhipple commented Sep 10, 2019

Thanks for the pointers guys; this appears to be working in all contexts now:

$ for attr in aws-adfs python3Packages.aws-adfs python2Packages.aws-adfs; do $(nix-build -A $attr)/bin/aws-adfs --version; done
1.17.0
1.17.0
1.17.0

@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
@marsam marsam merged commit a21d113 into NixOS:master Sep 22, 2019
@marsam
Copy link
Contributor

marsam commented Sep 22, 2019

Thanks @bhipple and @jonringer

@bhipple bhipple deleted the u/aws-adfs branch December 3, 2019 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle left review comments

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bhipple @marsam @risicle @jonringer @lheckemann