Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/airsonic: Fix user configuration #68219

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

nixos/airsonic: Fix user configuration #68219

wants to merge 1 commit into from
+7 −6

Conversation

wldhx
Copy link
Member

@wldhx wldhx commented Sep 6, 2019

Motivation for this change

The service used to start with User = airsonic regardless of cfg.user. This PR also replaces the weird users.users.airsonic.name = cfg.user construction with "create a user if default name (airsonic) is specified, otherwise leave user mgt to the admin" logic.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @disassembler

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 6, 2019
aanderse
aanderse requested changes Sep 6, 2019
View reviewed changes
@wldhx wldhx force-pushed the dev-airsonic-service-user branch from 21f393d to 973519a Compare September 6, 2019 23:54
@wldhx
Copy link
Member Author

wldhx commented Sep 6, 2019

@aanderse Thanks, updated!

@wldhx wldhx force-pushed the dev-airsonic-service-user branch from 973519a to 96dd753 Compare September 7, 2019 00:33
@wldhx
nixos/airsonic: Fix user configuration

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b88f807
@wldhx wldhx force-pushed the dev-airsonic-service-user branch from 96dd753 to b88f807 Compare September 8, 2019 18:32
@bjornfor
Copy link
Contributor

The commit message misses the useful info that you wrote in the PR message. Can you add it? (Tip: if you start with the commit message, github will copy that to the PR message for free. But it doesn't work the other way.)

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Nov 2, 2019

ping. Can you rebase?

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@ryantm ryantm added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 3, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@stale
Copy link

stale bot commented Apr 7, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 7, 2021
@wegank wegank added the 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people label Sep 7, 2023
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 7, 2023
@tomfitzhenry
Copy link
Contributor

@wldhx, friendly ping :) This PR looks like it's still valid and a good idea, it just needs to address #68219 (comment) and #68219 (comment)

@GetPsyched
Copy link
Member

OP is unresponsive. I think it would be better for someone to step in and add the requested changes along with a co-author mention.

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
@wegank wegank marked this pull request as draft March 20, 2024 15:12
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor

@rnhmjoj rnhmjoj

@aanderse aanderse

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@wldhx @bjornfor @rnhmjoj @tomfitzhenry @GetPsyched @aanderse @ryantm @wegank