Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.can: 3.1.0 -> 3.3.1 #68259

Merged
merged 2 commits into from Sep 8, 2019
Merged

pythonPackages.can: 3.1.0 -> 3.3.1 #68259

merged 2 commits into from Sep 8, 2019

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented Sep 7, 2019

Motivation for this change

Update Python package can. Python 2.7 doesn't seem to work anymore and the support is being dropped upstream anyway, so I dropped support here already. More info: hardbyte/python-can#699

I also added a new dependency and switched from GitHub source to PyPI source now that tests were added to the PyPI tarball.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jluttine jluttine requested a review from FRidh as a code owner September 7, 2019 12:16
@ofborg ofborg bot requested a review from sorki September 7, 2019 12:29
@jluttine
Copy link
Member Author

jluttine commented Sep 7, 2019

Oh, wait, I can make it work on Python 2 by upgrading hypothesis package. Just a sec, I'll make some changes and push them.

@jluttine
Copy link
Member Author

jluttine commented Sep 7, 2019

So, I needed to upgrade hypothesis package to make Python 2 work. Another Python package XlsxWriter also required this updated version of hypothesis in order for its update to work, so I just added all these three updates to this same PR. I'm now running nox review..

@jluttine
Copy link
Member Author

jluttine commented Sep 7, 2019

cc: python-can maintainer @sorki

@FRidh
Copy link
Member

FRidh commented Sep 7, 2019

hypothesis goes to staging and needs to be tested in a separate job

FRidh
FRidh requested changes Sep 7, 2019
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not bump hypothesis in this PR if we can avoid it

@jluttine
Copy link
Member Author

jluttine commented Sep 7, 2019

@FRidh I guess one solution is to disable the failing tests for Python 2 temporarily for these two packages, and add a comment that the disabling can be removed once hypothesis has been upgraded. Would that be a good solution?

@jluttine
Copy link
Member Author

jluttine commented Sep 8, 2019

@FRidh I now removed the need to update hypothesis by disabling tests for python-can under Python 2.7 with hypothesis version 4.7.3. I ran nox-review and everything passed.

@FRidh FRidh merged commit 766f0d0 into NixOS:master Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

@sorki sorki Awaiting requested review from sorki

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jluttine @FRidh