Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pvlib: 0.6.1 -> 0.6.3 #68253

Merged
merged 1 commit into from Sep 8, 2019
Merged

pythonPackages.pvlib: 0.6.1 -> 0.6.3 #68253

merged 1 commit into from Sep 8, 2019

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented Sep 7, 2019

Motivation for this change

Update pvlib Python package. This includes the following changes:

  • Now that pvlib PyPI package contains tests, use that instead of GitHub.
  • Drop support for Python <3.5.
  • Add new dependency requests.
  • Skip yet another new test that tries to use network.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jluttine jluttine requested a review from FRidh as a code owner September 7, 2019 11:35
@FRidh
Copy link
Member

FRidh commented Sep 7, 2019

@GrahamcOfBorg build pythonPackages.pvlib

@risicle
Copy link
Contributor

risicle commented Sep 7, 2019

nix-review WFM macos 10.13

@FRidh FRidh merged commit 8e814a8 into NixOS:master Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jluttine @FRidh @risicle