Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth-typing: 2.0.0 -> 2.1.0 and eth-utils: 1.4.1 -> 1.7.0 #68252

Merged
merged 2 commits into from
Sep 9, 2019
Merged

eth-typing: 2.0.0 -> 2.1.0 and eth-utils: 1.4.1 -> 1.7.0 #68252

merged 2 commits into from
Sep 9, 2019
+4 −4

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented Sep 7, 2019

Motivation for this change

Update eth-utils and eth-typing packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@jluttine jluttine requested a review from FRidh as a code owner September 7, 2019 11:16
@ofborg ofborg bot added 6.topic: python 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 7, 2019
@risicle
Copy link
Contributor

risicle commented Sep 8, 2019

nix-review builds on macos 10.13, only failing on electrum because of another of its dependencies failing.

@FRidh
Copy link
Member

FRidh commented Sep 8, 2019

@GrahamcOfBorg build python3.pkgs.eth-typing python3.pkgs.eth-utils

@mmahut mmahut merged commit b7d6a11 into NixOS:master Sep 9, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 22, 2019
@mmahut @dtzWill
Merge pull request NixOS#68252 from jluttine/eth-typing-2.1.0
572fc07 
eth-typing: 2.0.0 -> 2.1.0 and eth-utils: 1.4.1 -> 1.7.0
(cherry picked from commit b7d6a11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jluttine @risicle @FRidh @mmahut