gmic & gmic-qt: update & clean-up #68257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
jtojnar
force-pushed
the
gmic
branch
2 times, most recently
from
b105f0f
to
40ce89e
Compare
* Use qt5’s mkDerivation * Also switch gimpPlugins.gmic to qmic-qt
|
Verified that the GIMP plug-in works. |
|
|
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Sep 18, 2019
gmic & gmic-qt: update & clean-up (cherry picked from commit b27da0d)
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Previously, we had
gmicpackage that contained agimpPluginoutput with GTK plug-in for GIMP. That plug-in was dropped upstream, in favour of multiple Qt plug-ins inside ofgmic-qt. We already had an older version ofgmic-qtpackaged for Krita, so I generalized it. I updated both packages and cleaned them up significantly.Initially, I wanted to link gmic-qt against the packaged gmic library but the convoluted build system just does not like it. gmic headers point to
./CImg.h, which is not there, gmic-qt expects cpp files from gmic in../src…Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)gmic-qt(standalone) runs and at least some filters workgmic-qt-gimpis loaded and at least some filters workgmic-qt-kritais loaded and at least some filters worknix path-info -Sbefore and after)Notify maintainers
cc @AndersonTorres (cimg), @rycee (gmic), @nek0 (gmic-qt)