Luarocks nix bump #68258
Merged
Luarocks nix bump #68258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we now pass a configuration file when calling luarocks to prevent impurities.
luarocks defines by default the following mirrors: https://github.com/luarocks/luarocks/blob/83093e7da7f789f0f7d3a6784597cbbed09c73e0/src/luarocks/core/cfg.lua#L205 Let's add them to nixpkgs. I have modified luarocks-nix to generate the proper nixpkgs urls. I bump luarocks-nix in the following commits.
|
CC @Shados . while running the update script I had a few issues because parallel tends to hide the error. I just see: without being able to retrieve the error message. I don't know parallel but I wondered if the situation could be improved ? |
|
@teto the way parallel is set up, it should still output all the stdout/stderr for the called function, but it will do so in the order that the calls are made, so you may need to scrollback a bit to find the output for the failing call. |
|
cc @doronbehar since you are a lua user :) |
added version and transferred the repostiory to nix-community. With this bump, luarocks-nix generates mirro://luarocks urls.
teto
force-pushed
the
luarocks-nix_bump
branch
from
27806a1
to
4a31890
Compare
|
due to moving luarocks-nix to nix-community, luarocks-nix is broken in nixpkgs so I will merge this since in my tests it work. If there is an issue, I will fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
According to #68158, it seems like update-luarocks-packages will return different urls depending on the mirror hit.
I've thus proceeded to rebase luarocks-nix on top of the new luarocks-release 3.2.1 #68201 and added support for the generation of
mirror://luarocks/<PACKAGE_NAME> when possible.
The updater will also now look into a specific LUAROCKS_CONFIG to prevent outside impurities.
It allows to set some settings to let it perform better.
I've successfully regenerated a pkgs/development/lua-modules/generated-packages.nix with this.
Seems like package installation works with the new mirror://luarocks uris. (except for penlight).
I haven't submitted the pkgs/development/lua-modules/generated-packages.nix changes, I prefer to let it update itself little by little :)
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @